2017-08-27 12:55:29

by Priit Laes

[permalink] [raw]
Subject: [PATCH] Revert "pinctrl: sunxi: Don't enforce bias disable (for now)"

This reverts commit 2154d94b40ea2a5de05245521371d0461bb0d669.

The original patch was intented to avoid some issues with the sunxi
gpio rework and was supposed to be reverted after all the required
DT bits had been merged around v4.10.

Signed-off-by: Priit Laes <[email protected]>
---
drivers/pinctrl/sunxi/pinctrl-sunxi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/pinctrl/sunxi/pinctrl-sunxi.c b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
index 0dfd7fa66c48..52edf3b5988d 100644
--- a/drivers/pinctrl/sunxi/pinctrl-sunxi.c
+++ b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
@@ -564,7 +564,8 @@ static int sunxi_pconf_group_set(struct pinctrl_dev *pctldev,
val = arg / 10 - 1;
break;
case PIN_CONFIG_BIAS_DISABLE:
- continue;
+ val = 0;
+ break;
case PIN_CONFIG_BIAS_PULL_UP:
if (arg == 0)
return -EINVAL;
--
2.13.5


2017-08-28 06:46:46

by Maxime Ripard

[permalink] [raw]
Subject: Re: [PATCH] Revert "pinctrl: sunxi: Don't enforce bias disable (for now)"

1;4803;0c
On Sun, Aug 27, 2017 at 03:55:23PM +0300, Priit Laes wrote:
> This reverts commit 2154d94b40ea2a5de05245521371d0461bb0d669.
>
> The original patch was intented to avoid some issues with the sunxi
> gpio rework and was supposed to be reverted after all the required
> DT bits had been merged around v4.10.
>
> Signed-off-by: Priit Laes <[email protected]>

Acked-by: Maxime Ripard <[email protected]>

Thanks!
Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Attachments:
(No filename) (540.00 B)
 signature.asc (801.00 B)
 Download all attachments

2017-08-31 13:53:52

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH] Revert "pinctrl: sunxi: Don't enforce bias disable (for now)"

On Sun, Aug 27, 2017 at 2:55 PM, Priit Laes <[email protected]> wrote:

> This reverts commit 2154d94b40ea2a5de05245521371d0461bb0d669.
>
> The original patch was intented to avoid some issues with the sunxi
> gpio rework and was supposed to be reverted after all the required
> DT bits had been merged around v4.10.
>
> Signed-off-by: Priit Laes <[email protected]>

Patch applied with Maxime's ACK.

Yours,
Linus Walleij