2017-08-26 11:28:45

by Arvind Yadav

Subject: [PATCH] sparc: leon: grpci2: constify of_device_id

of_device_id are not supposed to change at runtime. All functions
working with of_device_id provided by <linux/of.h> work with const
of_device_ids. So mark the const and __initconst.

Signed-off-by: Arvind Yadav <[email protected]>
---
arch/sparc/kernel/leon_pci_grpci2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/sparc/kernel/leon_pci_grpci2.c b/arch/sparc/kernel/leon_pci_grpci2.c
index f727c4d..ff0e5c9 100644
--- a/arch/sparc/kernel/leon_pci_grpci2.c
+++ b/arch/sparc/kernel/leon_pci_grpci2.c
@@ -886,7 +886,7 @@ static int grpci2_of_probe(struct platform_device *ofdev)
return err;
}

-static struct of_device_id grpci2_of_match[] = {
+static const struct of_device_id grpci2_of_match[] __initconst = {
{
.name = "GAISLER_GRPCI2",
},
--
2.7.4

2017-08-26 11:28:58

by Arvind Yadav

Subject: [PATCH] sparc: leon: grpci1: constify of_device_id

of_device_id are not supposed to change at runtime. All functions
working with of_device_id provided by <linux/of.h> work with const
of_device_ids. So mark the const and __initconst.

Signed-off-by: Arvind Yadav <[email protected]>
---
arch/sparc/kernel/leon_pci_grpci1.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/sparc/kernel/leon_pci_grpci1.c b/arch/sparc/kernel/leon_pci_grpci1.c
index 1e77128..c5fc762 100644
--- a/arch/sparc/kernel/leon_pci_grpci1.c
+++ b/arch/sparc/kernel/leon_pci_grpci1.c
@@ -695,7 +695,7 @@ static int grpci1_of_probe(struct platform_device *ofdev)
return err;
}

-static struct of_device_id grpci1_of_match[] = {
+static const struct of_device_id grpci1_of_match[] __initconst = {
{
.name = "GAISLER_PCIFBRG",
},
--
2.7.4

2017-08-28 22:49:02

by David Miller

Subject: Re: [PATCH] sparc: leon: grpci2: constify of_device_id

From: Arvind Yadav <[email protected]>
Date: Sat, 26 Aug 2017 16:58:34 +0530

> of_device_id are not supposed to change at runtime. All functions
> working with of_device_id provided by <linux/of.h> work with const
> of_device_ids. So mark the const and __initconst.
>
> Signed-off-by: Arvind Yadav <[email protected]>

Applied.

2017-08-28 22:49:08

by David Miller

Subject: Re: [PATCH] sparc: leon: grpci1: constify of_device_id

From: Arvind Yadav <[email protected]>
Date: Sat, 26 Aug 2017 16:58:48 +0530

> of_device_id are not supposed to change at runtime. All functions
> working with of_device_id provided by <linux/of.h> work with const
> of_device_ids. So mark the const and __initconst.
>
> Signed-off-by: Arvind Yadav <[email protected]>

Applied.