2017-08-30 17:04:27

by Gustavo A. R. Silva

Subject: [PATCH] rtlwifi: rtl8723be: fix duplicated code for different branches

Refactor code in order to avoid identical code for different branches.

Addresses-Coverity-ID: 1248728
Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
This issue was reported by Coverity and it was tested by compilation only.
Please, verify if this is not a copy/paste error.
Also, notice this code has been there since 2014.

drivers/net/wireless/realtek/rtlwifi/rtl8723be/dm.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/dm.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/dm.c
index 131c0d1..15c117e 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/dm.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/dm.c
@@ -883,12 +883,8 @@ static void rtl8723be_dm_txpower_tracking_callback_thermalmeter(
if ((rtldm->power_index_offset[RF90_PATH_A] != 0) &&
(rtldm->txpower_track_control)) {
rtldm->done_txpower = true;
- if (thermalvalue > rtlefuse->eeprom_thermalmeter)
- rtl8723be_dm_tx_power_track_set_power(hw, BBSWING, 0,
- index_for_channel);
- else
- rtl8723be_dm_tx_power_track_set_power(hw, BBSWING, 0,
- index_for_channel);
+ rtl8723be_dm_tx_power_track_set_power(hw, BBSWING, 0,
+ index_for_channel);

rtldm->swing_idx_cck_base = rtldm->swing_idx_cck;
rtldm->swing_idx_ofdm_base[RF90_PATH_A] =
--
2.5.0

2017-08-31 04:42:25

by Larry Finger

Subject: Re: [PATCH] rtlwifi: rtl8723be: fix duplicated code for different branches

On 08/30/2017 12:04 PM, Gustavo A. R. Silva wrote:
> Refactor code in order to avoid identical code for different branches.
>
> Addresses-Coverity-ID: 1248728
> Signed-off-by: Gustavo A. R. Silva <[email protected]>

According to Realtek, this change is OK.

Acked-by: Larry Finger <[email protected]>

Thanks,

Larry

> ---
> This issue was reported by Coverity and it was tested by compilation only.
> Please, verify if this is not a copy/paste error.
> Also, notice this code has been there since 2014.
>
> drivers/net/wireless/realtek/rtlwifi/rtl8723be/dm.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/dm.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/dm.c
> index 131c0d1..15c117e 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/dm.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/dm.c
> @@ -883,12 +883,8 @@ static void rtl8723be_dm_txpower_tracking_callback_thermalmeter(
> if ((rtldm->power_index_offset[RF90_PATH_A] != 0) &&
> (rtldm->txpower_track_control)) {
> rtldm->done_txpower = true;
> - if (thermalvalue > rtlefuse->eeprom_thermalmeter)
> - rtl8723be_dm_tx_power_track_set_power(hw, BBSWING, 0,
> - index_for_channel);
> - else
> - rtl8723be_dm_tx_power_track_set_power(hw, BBSWING, 0,
> - index_for_channel);
> + rtl8723be_dm_tx_power_track_set_power(hw, BBSWING, 0,
> + index_for_channel);
>
> rtldm->swing_idx_cck_base = rtldm->swing_idx_cck;
> rtldm->swing_idx_ofdm_base[RF90_PATH_A] =
>

2017-08-31 13:00:23

by Kalle Valo

Subject: Re: rtlwifi: rtl8723be: fix duplicated code for different branches

"Gustavo A. R. Silva" <[email protected]> wrote:

> Refactor code in order to avoid identical code for different branches.
>
> Addresses-Coverity-ID: 1248728
> Signed-off-by: Gustavo A. R. Silva <[email protected]>
> Acked-by: Larry Finger <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

a9a65a6b2b69 rtlwifi: rtl8723be: fix duplicated code for different branches

--
https://patchwork.kernel.org/patch/9930325/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches