2017-09-05 12:16:33

by Dragos Bogdan

Subject: [PATCH 2/2] iio: ad7793: Fix the serial interface reset

The serial interface can be reset by writing 32 consecutive 1s to the device.
'ret' was initialized correctly but its value was overwritten when
ad7793_check_platform_data() was called. Since a dedicated reset function
is present now, it should be used instead.

Fixes: 2edb769d246e ("iio:ad7793: Add support for the ad7798 and ad7799")
Signed-off-by: Dragos Bogdan <[email protected]>
---
drivers/iio/adc/ad7793.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/adc/ad7793.c b/drivers/iio/adc/ad7793.c
index e6706a09e100..47c3d7f32900 100644
--- a/drivers/iio/adc/ad7793.c
+++ b/drivers/iio/adc/ad7793.c
@@ -257,7 +257,7 @@ static int ad7793_setup(struct iio_dev *indio_dev,
unsigned int vref_mv)
{
struct ad7793_state *st = iio_priv(indio_dev);
- int i, ret = -1;
+ int i, ret;
unsigned long long scale_uv;
u32 id;

@@ -266,7 +266,7 @@ static int ad7793_setup(struct iio_dev *indio_dev,
return ret;

/* reset the serial interface */
- ret = spi_write(st->sd.spi, (u8 *)&ret, sizeof(ret));
+ ret = ad_sd_reset(&st->sd, 32);
if (ret < 0)
goto out;
usleep_range(500, 2000); /* Wait for at least 500us */
--
2.11.0

2017-09-05 12:43:28

by Lars-Peter Clausen

Subject: Re: [PATCH 2/2] iio: ad7793: Fix the serial interface reset

On 09/05/2017 02:16 PM, Dragos Bogdan wrote:
> The serial interface can be reset by writing 32 consecutive 1s to the device.
> 'ret' was initialized correctly but its value was overwritten when
> ad7793_check_platform_data() was called. Since a dedicated reset function
> is present now, it should be used instead.
>
> Fixes: 2edb769d246e ("iio:ad7793: Add support for the ad7798 and ad7799")
> Signed-off-by: Dragos Bogdan <[email protected]>

Acked-by: Lars-Peter Clausen <[email protected]>

> ---
> drivers/iio/adc/ad7793.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/adc/ad7793.c b/drivers/iio/adc/ad7793.c
> index e6706a09e100..47c3d7f32900 100644
> --- a/drivers/iio/adc/ad7793.c
> +++ b/drivers/iio/adc/ad7793.c
> @@ -257,7 +257,7 @@ static int ad7793_setup(struct iio_dev *indio_dev,
> unsigned int vref_mv)
> {
> struct ad7793_state *st = iio_priv(indio_dev);
> - int i, ret = -1;
> + int i, ret;
> unsigned long long scale_uv;
> u32 id;
>
> @@ -266,7 +266,7 @@ static int ad7793_setup(struct iio_dev *indio_dev,
> return ret;
>
> /* reset the serial interface */
> - ret = spi_write(st->sd.spi, (u8 *)&ret, sizeof(ret));
> + ret = ad_sd_reset(&st->sd, 32);
> if (ret < 0)
> goto out;
> usleep_range(500, 2000); /* Wait for at least 500us */
>

2017-09-10 15:25:16

by Jonathan Cameron

Subject: Re: [PATCH 2/2] iio: ad7793: Fix the serial interface reset

On Tue, 5 Sep 2017 14:17:21 +0200
Lars-Peter Clausen <[email protected]> wrote:

> On 09/05/2017 02:16 PM, Dragos Bogdan wrote:
> > The serial interface can be reset by writing 32 consecutive 1s to the device.
> > 'ret' was initialized correctly but its value was overwritten when
> > ad7793_check_platform_data() was called. Since a dedicated reset function
> > is present now, it should be used instead.
> >
> > Fixes: 2edb769d246e ("iio:ad7793: Add support for the ad7798 and ad7799")
> > Signed-off-by: Dragos Bogdan <[email protected]>
>
> Acked-by: Lars-Peter Clausen <[email protected]>

Applied to the fixes-togreg branch of iio.git and marked
for stable.

Thanks

Jonathan
>
> > ---
> > drivers/iio/adc/ad7793.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/iio/adc/ad7793.c b/drivers/iio/adc/ad7793.c
> > index e6706a09e100..47c3d7f32900 100644
> > --- a/drivers/iio/adc/ad7793.c
> > +++ b/drivers/iio/adc/ad7793.c
> > @@ -257,7 +257,7 @@ static int ad7793_setup(struct iio_dev *indio_dev,
> > unsigned int vref_mv)
> > {
> > struct ad7793_state *st = iio_priv(indio_dev);
> > - int i, ret = -1;
> > + int i, ret;
> > unsigned long long scale_uv;
> > u32 id;
> >
> > @@ -266,7 +266,7 @@ static int ad7793_setup(struct iio_dev *indio_dev,
> > return ret;
> >
> > /* reset the serial interface */
> > - ret = spi_write(st->sd.spi, (u8 *)&ret, sizeof(ret));
> > + ret = ad_sd_reset(&st->sd, 32);
> > if (ret < 0)
> > goto out;
> > usleep_range(500, 2000); /* Wait for at least 500us */
> >
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html