2017-09-11 20:03:51

by Arnd Bergmann

Subject: [PATCH] signal: remove unused variable

The get_compat_sigset() cleanup missed a variable that is now unused:

kernel/signal.c: In function 'C_SYSC_rt_sigaction':
kernel/signal.c:3443:19: error: unused variable 'mask' [-Werror=unused-variable]

Fixes: 9b24ec57688a ("get_compat_sigset()")
Signed-off-by: Arnd Bergmann <[email protected]>
---
kernel/signal.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/kernel/signal.c b/kernel/signal.c
index 3198a7d2e5ff..36a523640894 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -3440,7 +3440,6 @@ COMPAT_SYSCALL_DEFINE4(rt_sigaction, int, sig,

if (act) {
compat_uptr_t handler;
- compat_sigset_t mask;
ret = get_user(handler, &act->sa_handler);
new_ka.sa.sa_handler = compat_ptr(handler);
#ifdef __ARCH_HAS_SA_RESTORER
--
2.9.0

2017-09-14 07:36:09

by Christos Gkekas

Subject: Re: [PATCH] signal: remove unused variable

On 11/09/17 22:03:37 +0200, Arnd Bergmann wrote:
> The get_compat_sigset() cleanup missed a variable that is now unused:
>
> kernel/signal.c: In function 'C_SYSC_rt_sigaction':
> kernel/signal.c:3443:19: error: unused variable 'mask' [-Werror=unused-variable]
>
> Fixes: 9b24ec57688a ("get_compat_sigset()")
> Signed-off-by: Arnd Bergmann <[email protected]>
> ---
> kernel/signal.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/kernel/signal.c b/kernel/signal.c
> index 3198a7d2e5ff..36a523640894 100644
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -3440,7 +3440,6 @@ COMPAT_SYSCALL_DEFINE4(rt_sigaction, int, sig,
>
> if (act) {
> compat_uptr_t handler;
> - compat_sigset_t mask;
> ret = get_user(handler, &act->sa_handler);
> new_ka.sa.sa_handler = compat_ptr(handler);
> #ifdef __ARCH_HAS_SA_RESTORER
> --
> 2.9.0
>


Thanks,

Acked-by: Christos Gkekas <[email protected]>