2017-09-08 17:53:30

by Harsha Sharma

[permalink] [raw]
Subject: [PATCH v3] staging: typec: tcpm: Rewrite comparison to NULL pointer

Make code more concise and readable

Signed-off-by: Harsha Sharma <[email protected]>
---
Change in v3:
-Change in subject and log message
Change in v2:
-Change in subject
-Change in log message
drivers/staging/typec/tcpm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/typec/tcpm.c b/drivers/staging/typec/tcpm.c
index 630fe75..9f4a5a5 100644
--- a/drivers/staging/typec/tcpm.c
+++ b/drivers/staging/typec/tcpm.c
@@ -982,7 +982,7 @@ static void svdm_consume_modes(struct tcpm_port *port, const __le32 *payload,
}
port->partner_altmode[pmdata->altmodes] =
typec_partner_register_altmode(port->partner, paltmode);
- if (port->partner_altmode[pmdata->altmodes] == NULL) {
+ if (!port->partner_altmode[pmdata->altmodes]) {
tcpm_log(port,
"Failed to register alternate modes for SVID 0x%04x",
paltmode->svid);
--
1.9.1


2017-09-08 18:01:58

by Julia Lawall

[permalink] [raw]
Subject: Re: [Outreachy kernel] [PATCH v3] staging: typec: tcpm: Rewrite comparison to NULL pointer



On Fri, 8 Sep 2017, Harsha Sharma wrote:

> Make code more concise and readable
>
> Signed-off-by: Harsha Sharma <[email protected]>

Acked-by: Julia Lawall <[email protected]>

> ---
> Change in v3:
> -Change in subject and log message
> Change in v2:
> -Change in subject
> -Change in log message
> drivers/staging/typec/tcpm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/typec/tcpm.c b/drivers/staging/typec/tcpm.c
> index 630fe75..9f4a5a5 100644
> --- a/drivers/staging/typec/tcpm.c
> +++ b/drivers/staging/typec/tcpm.c
> @@ -982,7 +982,7 @@ static void svdm_consume_modes(struct tcpm_port *port, const __le32 *payload,
> }
> port->partner_altmode[pmdata->altmodes] =
> typec_partner_register_altmode(port->partner, paltmode);
> - if (port->partner_altmode[pmdata->altmodes] == NULL) {
> + if (!port->partner_altmode[pmdata->altmodes]) {
> tcpm_log(port,
> "Failed to register alternate modes for SVID 0x%04x",
> paltmode->svid);
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
> To post to this group, send email to [email protected].
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1504893085-6113-1-git-send-email-harshasharmaiitr%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

2017-09-12 20:43:19

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH v3] staging: typec: tcpm: Rewrite comparison to NULL pointer

On Fri, Sep 08, 2017 at 11:21:25PM +0530, Harsha Sharma wrote:
> Make code more concise and readable
>
> Signed-off-by: Harsha Sharma <[email protected]>
> ---
> Change in v3:
> -Change in subject and log message
> Change in v2:
> -Change in subject
> -Change in log message
> drivers/staging/typec/tcpm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Due to other things happening in this driver, I have to wait until after
4.14-rc1 is out before I can apply it. Don't worry, it's not lost, I
just have to postpone it for another week...

thanks,

greg k-h