The broken lockup_detector_suspend/resume() interface is going away. Use
the new lockup_detector_soft_poweroff() interface to stop the watchdog from
the busy looping power off routine.
Signed-off-by: Thomas Gleixner <[email protected]>
Cc: Don Zickus <[email protected]>
Cc: Chris Metcalf <[email protected]>
Cc: [email protected]
Cc: Peter Zijlstra <[email protected]>
Cc: Sebastian Siewior <[email protected]>
Cc: Nicholas Piggin <[email protected]>
Cc: Ulrich Obergfell <[email protected]>
Cc: Borislav Petkov <[email protected]>
Cc: Andrew Morton <[email protected]>
Cc: Helge Deller <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
---
arch/parisc/kernel/process.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/arch/parisc/kernel/process.c
+++ b/arch/parisc/kernel/process.c
@@ -146,7 +146,7 @@ void machine_power_off(void)
/* prevent soft lockup/stalled CPU messages for endless loop. */
rcu_sysrq_start();
- lockup_detector_suspend();
+ lockup_detector_soft_poweroff();
for (;;);
}
* Thomas Gleixner <[email protected]>:
> The broken lockup_detector_suspend/resume() interface is going away. Use
> the new lockup_detector_soft_poweroff() interface to stop the watchdog from
> the busy looping power off routine.
>
> Signed-off-by: Thomas Gleixner <[email protected]>
> Cc: Don Zickus <[email protected]>
> Cc: Chris Metcalf <[email protected]>
> Cc: [email protected]
> Cc: Peter Zijlstra <[email protected]>
> Cc: Sebastian Siewior <[email protected]>
> Cc: Nicholas Piggin <[email protected]>
> Cc: Ulrich Obergfell <[email protected]>
> Cc: Borislav Petkov <[email protected]>
> Cc: Andrew Morton <[email protected]>
> Cc: Helge Deller <[email protected]>
> Link: http://lkml.kernel.org/r/[email protected]
>
> ---
> arch/parisc/kernel/process.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/arch/parisc/kernel/process.c
> +++ b/arch/parisc/kernel/process.c
> @@ -146,7 +146,7 @@ void machine_power_off(void)
>
> /* prevent soft lockup/stalled CPU messages for endless loop. */
> rcu_sysrq_start();
> - lockup_detector_suspend();
> + lockup_detector_soft_poweroff();
> for (;;);
> }
Thomas, thanks for cleaning that up.
You may add to patches 03/04:
Acked-by: Helge Deller <[email protected]>
On a side-note, there is sadly no general function like
turn_off_all_kind_of_runtime_hang_detectors()
which turns off *all* detectors at once (including soft lockup detector).
I've seen another detector complaing at runtime that we were hanging
here. I would need to dig up more info if you are interested...
Helge
Commit-ID: 47bb4baf7df43ac8bbc51c24022466972ba29ef1
Gitweb: http://git.kernel.org/tip/47bb4baf7df43ac8bbc51c24022466972ba29ef1
Author: Thomas Gleixner <[email protected]>
AuthorDate: Tue, 12 Sep 2017 21:36:58 +0200
Committer: Ingo Molnar <[email protected]>
CommitDate: Thu, 14 Sep 2017 11:41:03 +0200
parisc, watchdog/core: Use lockup_detector_stop()
The broken lockup_detector_suspend/resume() interface is going away. Use
the new lockup_detector_soft_poweroff() interface to stop the watchdog from
the busy looping power off routine.
Signed-off-by: Thomas Gleixner <[email protected]>
Reviewed-by: Don Zickus <[email protected]>
Cc: Andrew Morton <[email protected]>
Cc: Borislav Petkov <[email protected]>
Cc: Chris Metcalf <[email protected]>
Cc: Helge Deller <[email protected]>
Cc: Linus Torvalds <[email protected]>
Cc: Nicholas Piggin <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Sebastian Siewior <[email protected]>
Cc: Ulrich Obergfell <[email protected]>
Cc: [email protected]
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Ingo Molnar <[email protected]>
---
arch/parisc/kernel/process.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/parisc/kernel/process.c b/arch/parisc/kernel/process.c
index a45a67d..30f9239 100644
--- a/arch/parisc/kernel/process.c
+++ b/arch/parisc/kernel/process.c
@@ -146,7 +146,7 @@ void machine_power_off(void)
/* prevent soft lockup/stalled CPU messages for endless loop. */
rcu_sysrq_start();
- lockup_detector_suspend();
+ lockup_detector_soft_poweroff();
for (;;);
}
On Thu, Sep 14, 2017 at 10:59:17AM +0200, Helge Deller wrote:
> * Thomas Gleixner <[email protected]>:
> > The broken lockup_detector_suspend/resume() interface is going away. Use
> > the new lockup_detector_soft_poweroff() interface to stop the watchdog from
> > the busy looping power off routine.
> >
> > Signed-off-by: Thomas Gleixner <[email protected]>
> > Cc: Don Zickus <[email protected]>
> > Cc: Chris Metcalf <[email protected]>
> > Cc: [email protected]
> > Cc: Peter Zijlstra <[email protected]>
> > Cc: Sebastian Siewior <[email protected]>
> > Cc: Nicholas Piggin <[email protected]>
> > Cc: Ulrich Obergfell <[email protected]>
> > Cc: Borislav Petkov <[email protected]>
> > Cc: Andrew Morton <[email protected]>
> > Cc: Helge Deller <[email protected]>
> > Link: http://lkml.kernel.org/r/[email protected]
> >
> > ---
> > arch/parisc/kernel/process.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > --- a/arch/parisc/kernel/process.c
> > +++ b/arch/parisc/kernel/process.c
> > @@ -146,7 +146,7 @@ void machine_power_off(void)
> >
> > /* prevent soft lockup/stalled CPU messages for endless loop. */
> > rcu_sysrq_start();
> > - lockup_detector_suspend();
> > + lockup_detector_soft_poweroff();
> > for (;;);
> > }
>
> Thomas, thanks for cleaning that up.
> You may add to patches 03/04:
> Acked-by: Helge Deller <[email protected]>
>
>
> On a side-note, there is sadly no general function like
> turn_off_all_kind_of_runtime_hang_detectors()
> which turns off *all* detectors at once (including soft lockup detector).
> I've seen another detector complaing at runtime that we were hanging
> here. I would need to dig up more info if you are interested...
There are numerous detectors I have seen over the years: rcu, clocksource,
hard/soft, hang, fs, network, wq?, etc.. I am not sure it is easy to put
them all in one place or makes sense.
I know working with the kvm folks, when they swap back in, the real clock
can do a massive jump forward and causes a flood of warnings such that they
had to 'touch' all of them before running the vm again.
Cheers,
Don