2017-09-17 16:58:43

by Cyrill Gorcunov

Subject: [PATCH] kcmp: Drop branch leftover typo

The else branch been leftover and escaped the source
code refresh. Not a problem but better clean it up.

Reported-by: Eugene Syromiatnikov <[email protected]>
Signed-off-by: Cyrill Gorcunov <[email protected]>
CC: Andrey Vagin <[email protected]>
CC: Andrew Morton <[email protected]>
CC: Pavel Emelyanov <[email protected]>
---
kernel/kcmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-ml.git/kernel/kcmp.c
===================================================================
--- linux-ml.git.orig/kernel/kcmp.c
+++ linux-ml.git/kernel/kcmp.c
@@ -131,7 +131,7 @@ static int kcmp_epoll_target(struct task
if (filp_epoll) {
filp_tgt = get_epoll_tfile_raw_ptr(filp_epoll, slot.tfd, slot.toff);
fput(filp_epoll);
- } else
+ }

if (IS_ERR(filp_tgt))
return PTR_ERR(filp_tgt);

2017-09-18 17:55:20

by Andrei Vagin

Subject: Re: [PATCH] kcmp: Drop branch leftover typo

Acked-by: Andrei Vagin <[email protected]>

Fixes: 0791e3644e5e ("kcmp: add KCMP_EPOLL_TFD mode to compare epoll target files")

On Sun, Sep 17, 2017 at 07:58:38PM +0300, Cyrill Gorcunov wrote:
> The else branch been leftover and escaped the source
> code refresh. Not a problem but better clean it up.
>
> Reported-by: Eugene Syromiatnikov <[email protected]>
> Signed-off-by: Cyrill Gorcunov <[email protected]>
> CC: Andrey Vagin <[email protected]>
> CC: Andrew Morton <[email protected]>
> CC: Pavel Emelyanov <[email protected]>
> ---
> kernel/kcmp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-ml.git/kernel/kcmp.c
> ===================================================================
> --- linux-ml.git.orig/kernel/kcmp.c
> +++ linux-ml.git/kernel/kcmp.c
> @@ -131,7 +131,7 @@ static int kcmp_epoll_target(struct task
> if (filp_epoll) {
> filp_tgt = get_epoll_tfile_raw_ptr(filp_epoll, slot.tfd, slot.toff);
> fput(filp_epoll);
> - } else
> + }
>
> if (IS_ERR(filp_tgt))
> return PTR_ERR(filp_tgt);