2017-09-19 14:54:59

by Michal Simek

Subject: [PATCH] microblaze: Add missing kvm_para.h to Kbuild

Running make allmodconfig;make is throwing compilation error:
CC kernel/watchdog.o
In file included from ./include/linux/kvm_para.h:4:0,
from kernel/watchdog.c:29:
./include/uapi/linux/kvm_para.h:32:26: fatal error: asm/kvm_para.h: No
such file or directory
#include <asm/kvm_para.h>
^
compilation terminated.
make[1]: *** [kernel/watchdog.o] Error 1
make: *** [kernel/watchdog.o] Error 2

Reported-by: Michal Hocko <[email protected]>
Suggested-by: Geert Uytterhoeven <[email protected]>
Signed-off-by: Michal Simek <[email protected]>
Fixes: 83f0124ad81e87b ("microblaze: remove asm-generic wrapper headers")
---

arch/microblaze/include/uapi/asm/Kbuild | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/microblaze/include/uapi/asm/Kbuild b/arch/microblaze/include/uapi/asm/Kbuild
index e77a596f3f1e..06609ca36115 100644
--- a/arch/microblaze/include/uapi/asm/Kbuild
+++ b/arch/microblaze/include/uapi/asm/Kbuild
@@ -7,6 +7,7 @@ generic-y += fcntl.h
generic-y += ioctl.h
generic-y += ioctls.h
generic-y += ipcbuf.h
+generic-y += kvm_para.h
generic-y += mman.h
generic-y += msgbuf.h
generic-y += param.h
--
1.9.1

2017-09-19 15:14:07

by Tobias Klauser

Subject: Re: [PATCH] microblaze: Add missing kvm_para.h to Kbuild

On 2017-09-19 at 16:54:54 +0200, Michal Simek <[email protected]> wrote:
> Running make allmodconfig;make is throwing compilation error:
> CC kernel/watchdog.o
> In file included from ./include/linux/kvm_para.h:4:0,
> from kernel/watchdog.c:29:
> ./include/uapi/linux/kvm_para.h:32:26: fatal error: asm/kvm_para.h: No
> such file or directory
> #include <asm/kvm_para.h>
> ^
> compilation terminated.
> make[1]: *** [kernel/watchdog.o] Error 1
> make: *** [kernel/watchdog.o] Error 2
>
> Reported-by: Michal Hocko <[email protected]>
> Suggested-by: Geert Uytterhoeven <[email protected]>
> Signed-off-by: Michal Simek <[email protected]>
> Fixes: 83f0124ad81e87b ("microblaze: remove asm-generic wrapper headers")

Ugh, I somehow missed kvm_para.h in my change. Thanks a lot for the fix!

Reviewed-by: Tobias Klauser <[email protected]>

2017-09-25 12:49:33

by Michal Hocko

Subject: Re: [PATCH] microblaze: Add missing kvm_para.h to Kbuild

On Tue 19-09-17 16:54:54, Michal Simek wrote:
> Running make allmodconfig;make is throwing compilation error:
> CC kernel/watchdog.o
> In file included from ./include/linux/kvm_para.h:4:0,
> from kernel/watchdog.c:29:
> ./include/uapi/linux/kvm_para.h:32:26: fatal error: asm/kvm_para.h: No
> such file or directory
> #include <asm/kvm_para.h>
> ^
> compilation terminated.
> make[1]: *** [kernel/watchdog.o] Error 1
> make: *** [kernel/watchdog.o] Error 2
>
> Reported-by: Michal Hocko <[email protected]>
> Suggested-by: Geert Uytterhoeven <[email protected]>
> Signed-off-by: Michal Simek <[email protected]>
> Fixes: 83f0124ad81e87b ("microblaze: remove asm-generic wrapper headers")

Sorry for a late answer, I was offline most of the last week
Tested-by: Michal Hocko <[email protected]>

Thanks!

> ---
>
> arch/microblaze/include/uapi/asm/Kbuild | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/microblaze/include/uapi/asm/Kbuild b/arch/microblaze/include/uapi/asm/Kbuild
> index e77a596f3f1e..06609ca36115 100644
> --- a/arch/microblaze/include/uapi/asm/Kbuild
> +++ b/arch/microblaze/include/uapi/asm/Kbuild
> @@ -7,6 +7,7 @@ generic-y += fcntl.h
> generic-y += ioctl.h
> generic-y += ioctls.h
> generic-y += ipcbuf.h
> +generic-y += kvm_para.h
> generic-y += mman.h
> generic-y += msgbuf.h
> generic-y += param.h
> --
> 1.9.1

--
Michal Hocko
SUSE Labs