2017-09-19 22:38:11

by Vito Caputo

Subject: [PATCH] net: ethernet: aquantia: default to no in config

NET_VENDOR_AQUANTIA was "default y" for some reason, which seems
obviously inappropriate.
---
drivers/net/ethernet/aquantia/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/aquantia/Kconfig b/drivers/net/ethernet/aquantia/Kconfig
index cdf78e069a39..6167b13cf349 100644
--- a/drivers/net/ethernet/aquantia/Kconfig
+++ b/drivers/net/ethernet/aquantia/Kconfig
@@ -4,7 +4,7 @@

config NET_VENDOR_AQUANTIA
bool "aQuantia devices"
- default y
+ default n
---help---
Set this to y if you have an Ethernet network cards that uses the aQuantia
AQC107/AQC108 chipset.
--
2.11.0

2017-09-19 22:52:33

by David Miller

Subject: Re: [PATCH] net: ethernet: aquantia: default to no in config

From: Vito Caputo <[email protected]>
Date: Tue, 19 Sep 2017 15:43:15 -0700

> NET_VENDOR_AQUANTIA was "default y" for some reason, which seems
> obviously inappropriate.

It is appropriate.

We make all vendor guards default to yes.

2017-09-19 22:57:45

by Vito Caputo

Subject: Re: [PATCH] net: ethernet: aquantia: default to no in config

On Tue, Sep 19, 2017 at 03:52:31PM -0700, David Miller wrote:
> From: Vito Caputo <[email protected]>
> Date: Tue, 19 Sep 2017 15:43:15 -0700
>
> > NET_VENDOR_AQUANTIA was "default y" for some reason, which seems
> > obviously inappropriate.
>
> It is appropriate.
>
> We make all vendor guards default to yes.

Thanks for the quick response.

Out of curiosity, what's the rationale for that decision?

2017-09-19 22:59:23

by David Miller

Subject: Re: [PATCH] net: ethernet: aquantia: default to no in config

From: [email protected]
Date: Tue, 19 Sep 2017 16:02:49 -0700

> Out of curiosity, what's the rationale for that decision?

So that you don't need to know what special vendor knob needs to be
switched in order to even be offered the config knob for the driver
you are interested in.

2017-09-20 10:28:30

by Sergei Shtylyov

Subject: Re: [PATCH] net: ethernet: aquantia: default to no in config

Hello!

On 9/20/2017 1:43 AM, Vito Caputo wrote:

> NET_VENDOR_AQUANTIA was "default y" for some reason, which seems
> obviously inappropriate.
> ---
> drivers/net/ethernet/aquantia/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/aquantia/Kconfig b/drivers/net/ethernet/aquantia/Kconfig
> index cdf78e069a39..6167b13cf349 100644
> --- a/drivers/net/ethernet/aquantia/Kconfig
> +++ b/drivers/net/ethernet/aquantia/Kconfig
> @@ -4,7 +4,7 @@
>
> config NET_VENDOR_AQUANTIA
> bool "aQuantia devices"
> - default y
> + default n

Just remove it -- 'n' is the default default. :-)

[...]

MBR, Sergei