2017-09-21 11:28:37

by Rakesh Pandit

Subject: [PATCH 6/6] lightnvm: include NVM Express driver if OCSSD is selected for build

Because NVM needs BLK_DEV_NVME, select it automatically if we mark NVM
in config file before building kernel.

Signed-off-by: Rakesh Pandit <[email protected]>
---
drivers/lightnvm/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/lightnvm/Kconfig b/drivers/lightnvm/Kconfig
index ead61a9..b3c00cb 100644
--- a/drivers/lightnvm/Kconfig
+++ b/drivers/lightnvm/Kconfig
@@ -5,6 +5,7 @@
menuconfig NVM
bool "Open-Channel SSD target support"
depends on BLOCK && HAS_DMA
+ select BLK_DEV_NVME
help
Say Y here to get to enable Open-channel SSDs.

--
2.5.0

2017-09-21 11:32:44

by Matias Bjørling

Subject: Re: [PATCH 6/6] lightnvm: include NVM Express driver if OCSSD is selected for build

On 09/21/2017 01:28 PM, Rakesh Pandit wrote:
> Because NVM needs BLK_DEV_NVME, select it automatically if we mark NVM
> in config file before building kernel.
>
> Signed-off-by: Rakesh Pandit <[email protected]>
> ---
> drivers/lightnvm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/lightnvm/Kconfig b/drivers/lightnvm/Kconfig
> index ead61a9..b3c00cb 100644
> --- a/drivers/lightnvm/Kconfig
> +++ b/drivers/lightnvm/Kconfig
> @@ -5,6 +5,7 @@
> menuconfig NVM
> bool "Open-Channel SSD target support"
> depends on BLOCK && HAS_DMA
> + select BLK_DEV_NVME
> help
> Say Y here to get to enable Open-channel SSDs.
>
>

Thanks Rakesh. I've picked it up for 4.15.

2017-09-21 13:40:03

by Rakesh Pandit

Subject: Re: [PATCH 6/6] lightnvm: include NVM Express driver if OCSSD is selected for build

On Thu, Sep 21, 2017 at 01:32:40PM +0200, Matias Bj?rling wrote:
> On 09/21/2017 01:28 PM, Rakesh Pandit wrote:
> > Because NVM needs BLK_DEV_NVME, select it automatically if we mark NVM
> > in config file before building kernel.
> >
> > Signed-off-by: Rakesh Pandit <[email protected]>
> > ---
> > drivers/lightnvm/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/lightnvm/Kconfig b/drivers/lightnvm/Kconfig
> > index ead61a9..b3c00cb 100644
> > --- a/drivers/lightnvm/Kconfig
> > +++ b/drivers/lightnvm/Kconfig
> > @@ -5,6 +5,7 @@
> > menuconfig NVM
> > bool "Open-Channel SSD target support"
> > depends on BLOCK && HAS_DMA
> > + select BLK_DEV_NVME
> > help
> > Say Y here to get to enable Open-channel SSDs.
> >
>
> Thanks Rakesh. I've picked it up for 4.15.

As discussed (IRC) I wasn't very careful first time and missed
appending PCI to depends as select doesn't visit dependencies
automatically. Will post a version 2 soon.

Will only post version 2 of this very patch.

Doesn't make sense to push anything else from set. Thank you in
advance,