2017-09-22 07:52:35

by Andi Shyti

Subject: [PATCH] Input: stmfts - use devm_device_add_group

instead of sysfs_create_group.

Signed-off-by: Andi Shyti <[email protected]>
---
drivers/input/touchscreen/stmfts.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/input/touchscreen/stmfts.c b/drivers/input/touchscreen/stmfts.c
index 157fdb4bb2e8..2351199189a4 100644
--- a/drivers/input/touchscreen/stmfts.c
+++ b/drivers/input/touchscreen/stmfts.c
@@ -727,8 +727,7 @@ static int stmfts_probe(struct i2c_client *client,
}
}

- err = sysfs_create_group(&sdata->client->dev.kobj,
- &stmfts_attribute_group);
+ err = devm_device_add_group(&client->dev, &stmfts_attribute_group);
if (err)
return err;

@@ -740,7 +739,6 @@ static int stmfts_probe(struct i2c_client *client,
static int stmfts_remove(struct i2c_client *client)
{
pm_runtime_disable(&client->dev);
- sysfs_remove_group(&client->dev.kobj, &stmfts_attribute_group);

return 0;
}
--
2.14.1

2017-09-22 17:06:31

by Dmitry Torokhov

Subject: Re: [PATCH] Input: stmfts - use devm_device_add_group

On Fri, Sep 22, 2017 at 04:52:38PM +0900, Andi Shyti wrote:
> instead of sysfs_create_group.
>
> Signed-off-by: Andi Shyti <[email protected]>

Applied, thank you.

> ---
> drivers/input/touchscreen/stmfts.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/input/touchscreen/stmfts.c b/drivers/input/touchscreen/stmfts.c
> index 157fdb4bb2e8..2351199189a4 100644
> --- a/drivers/input/touchscreen/stmfts.c
> +++ b/drivers/input/touchscreen/stmfts.c
> @@ -727,8 +727,7 @@ static int stmfts_probe(struct i2c_client *client,
> }
> }
>
> - err = sysfs_create_group(&sdata->client->dev.kobj,
> - &stmfts_attribute_group);
> + err = devm_device_add_group(&client->dev, &stmfts_attribute_group);
> if (err)
> return err;
>
> @@ -740,7 +739,6 @@ static int stmfts_probe(struct i2c_client *client,
> static int stmfts_remove(struct i2c_client *client)
> {
> pm_runtime_disable(&client->dev);
> - sysfs_remove_group(&client->dev.kobj, &stmfts_attribute_group);
>
> return 0;
> }
> --
> 2.14.1
>

--
Dmitry