2017-09-21 01:27:10

by Zhiyong Tao

[permalink] [raw]
Subject: [PATCH 0/3] AUXADC: Mediatek auxadc driver for mt2712

This series includes three patches:
1.Add mt2712 auxadc compatible node in binding document.
2.Add mt2712 auxadc compatible node in "mt6577_auxadc.c".
2.Add mt2712 auxadc device node.

Zhiyong Tao (3):
dt-bindings: adc: mt2712: add binding document
iio: adc: mt2712: Add compatible node for mt2712.
arm64: dts: mt2712: Add auxadc device node.

.../devicetree/bindings/iio/adc/mt6577_auxadc.txt | 1 +
arch/arm64/boot/dts/mediatek/mt2712-evb.dts | 4 ++++
arch/arm64/boot/dts/mediatek/mt2712e.dtsi | 9 +++++++++
drivers/iio/adc/mt6577_auxadc.c | 1 +
4 files changed, 15 insertions(+)

--
1.7.9.5


2017-09-21 01:27:12

by Zhiyong Tao

[permalink] [raw]
Subject: [PATCH 2/3] iio: adc: mt2712: Add compatible node for mt2712.

This commit adds mt2712 compatible node.

Signed-off-by: Zhiyong Tao <[email protected]>
---
drivers/iio/adc/mt6577_auxadc.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/iio/adc/mt6577_auxadc.c b/drivers/iio/adc/mt6577_auxadc.c
index 414cf44..70bfa1e 100644
--- a/drivers/iio/adc/mt6577_auxadc.c
+++ b/drivers/iio/adc/mt6577_auxadc.c
@@ -306,6 +306,7 @@ static SIMPLE_DEV_PM_OPS(mt6577_auxadc_pm_ops,

static const struct of_device_id mt6577_auxadc_of_match[] = {
{ .compatible = "mediatek,mt2701-auxadc", },
+ { .compatible = "mediatek,mt2712-auxadc", },
{ .compatible = "mediatek,mt7622-auxadc", },
{ .compatible = "mediatek,mt8173-auxadc", },
{ }
--
1.7.9.5

2017-09-21 01:27:11

by Zhiyong Tao

[permalink] [raw]
Subject: [PATCH 1/3] dt-bindings: adc: mt2712: add binding document

The commit adds mt2712 compatible node in binding document.

Signed-off-by: Zhiyong Tao <[email protected]>
---
.../devicetree/bindings/iio/adc/mt6577_auxadc.txt | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt b/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt
index 64dc484..0df9bef 100644
--- a/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt
+++ b/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt
@@ -12,6 +12,7 @@ for the Thermal Controller which holds a phandle to the AUXADC.
Required properties:
- compatible: Should be one of:
- "mediatek,mt2701-auxadc": For MT2701 family of SoCs
+ - "mediatek,mt2712-auxadc": For MT2712 family of SoCs
- "mediatek,mt7622-auxadc": For MT7622 family of SoCs
- "mediatek,mt8173-auxadc": For MT8173 family of SoCs
- reg: Address range of the AUXADC unit.
--
1.7.9.5

2017-09-21 01:27:08

by Zhiyong Tao

[permalink] [raw]
Subject: [PATCH 3/3] arm64: dts: mt2712: Add auxadc device node.

Add auxadc device node for MT2712.

Signed-off-by: Zhiyong Tao <[email protected]>
---
This patch dependents on "Mediatek MT2712 clock and scpsys support"[1].
Please accept this patch together with [1].
[1]http://lists.infradead.org/pipermail/linux-mediatek/2017-September/010461.html
---
arch/arm64/boot/dts/mediatek/mt2712-evb.dts | 4 ++++
arch/arm64/boot/dts/mediatek/mt2712e.dtsi | 9 +++++++++
2 files changed, 13 insertions(+)

diff --git a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
index 14163b9..76cbf4a 100644
--- a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
+++ b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
@@ -28,6 +28,10 @@
};
};

+&auxadc {
+ status = "okay";
+};
+
&uart0 {
status = "okay";
};
diff --git a/arch/arm64/boot/dts/mediatek/mt2712e.dtsi b/arch/arm64/boot/dts/mediatek/mt2712e.dtsi
index 3232e4e..bf65c92 100644
--- a/arch/arm64/boot/dts/mediatek/mt2712e.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt2712e.dtsi
@@ -225,6 +225,15 @@
(GIC_CPU_MASK_RAW(0x13) | IRQ_TYPE_LEVEL_HIGH)>;
};

+ auxadc: adc@11001000 {
+ compatible = "mediatek,mt2712-auxadc";
+ reg = <0 0x11001000 0 0x1000>;
+ clocks = <&pericfg CLK_PERI_AUXADC>;
+ clock-names = "main";
+ #io-channel-cells = <1>;
+ status = "disabled";
+ };
+
uart0: serial@11002000 {
compatible = "mediatek,mt2712-uart",
"mediatek,mt6577-uart";
--
1.7.9.5

2017-09-24 15:45:20

by Jonathan Cameron

[permalink] [raw]
Subject: Re: [PATCH 1/3] dt-bindings: adc: mt2712: add binding document

On Thu, 21 Sep 2017 09:26:50 +0800
Zhiyong Tao <[email protected]> wrote:

> The commit adds mt2712 compatible node in binding document.
>
> Signed-off-by: Zhiyong Tao <[email protected]>

Given just how trivial this is, I'm not going to waste Rob or Marks
time by waiting for them to look at it. I did tweak the patch
title to '... binding documentation' to reflect the fact this
isn't a new file which 'binding document' sort of implied.

Applied to the togreg branch of iio.git and pushed out as
testing for the autobuilders to play with it.

Thanks,

Jonathan

> ---
> .../devicetree/bindings/iio/adc/mt6577_auxadc.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt b/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt
> index 64dc484..0df9bef 100644
> --- a/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt
> +++ b/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt
> @@ -12,6 +12,7 @@ for the Thermal Controller which holds a phandle to the AUXADC.
> Required properties:
> - compatible: Should be one of:
> - "mediatek,mt2701-auxadc": For MT2701 family of SoCs
> + - "mediatek,mt2712-auxadc": For MT2712 family of SoCs
> - "mediatek,mt7622-auxadc": For MT7622 family of SoCs
> - "mediatek,mt8173-auxadc": For MT8173 family of SoCs
> - reg: Address range of the AUXADC unit.

2017-09-24 15:46:16

by Jonathan Cameron

[permalink] [raw]
Subject: Re: [PATCH 2/3] iio: adc: mt2712: Add compatible node for mt2712.

On Thu, 21 Sep 2017 09:26:51 +0800
Zhiyong Tao <[email protected]> wrote:

> This commit adds mt2712 compatible node.

Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.

Thanks,

Jonathan

>
> Signed-off-by: Zhiyong Tao <[email protected]>
> ---
> drivers/iio/adc/mt6577_auxadc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/adc/mt6577_auxadc.c b/drivers/iio/adc/mt6577_auxadc.c
> index 414cf44..70bfa1e 100644
> --- a/drivers/iio/adc/mt6577_auxadc.c
> +++ b/drivers/iio/adc/mt6577_auxadc.c
> @@ -306,6 +306,7 @@ static SIMPLE_DEV_PM_OPS(mt6577_auxadc_pm_ops,
>
> static const struct of_device_id mt6577_auxadc_of_match[] = {
> { .compatible = "mediatek,mt2701-auxadc", },
> + { .compatible = "mediatek,mt2712-auxadc", },
> { .compatible = "mediatek,mt7622-auxadc", },
> { .compatible = "mediatek,mt8173-auxadc", },
> { }

2017-09-24 15:47:13

by Jonathan Cameron

[permalink] [raw]
Subject: Re: [PATCH 3/3] arm64: dts: mt2712: Add auxadc device node.

On Thu, 21 Sep 2017 09:26:52 +0800
Zhiyong Tao <[email protected]> wrote:

> Add auxadc device node for MT2712.
>
> Signed-off-by: Zhiyong Tao <[email protected]>

I've applied the IIO patches to make this work, so assume this will get
picked up in due course.

Jonathan

> ---
> This patch dependents on "Mediatek MT2712 clock and scpsys support"[1].
> Please accept this patch together with [1].
> [1]http://lists.infradead.org/pipermail/linux-mediatek/2017-September/010461.html
> ---
> arch/arm64/boot/dts/mediatek/mt2712-evb.dts | 4 ++++
> arch/arm64/boot/dts/mediatek/mt2712e.dtsi | 9 +++++++++
> 2 files changed, 13 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
> index 14163b9..76cbf4a 100644
> --- a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
> @@ -28,6 +28,10 @@
> };
> };
>
> +&auxadc {
> + status = "okay";
> +};
> +
> &uart0 {
> status = "okay";
> };
> diff --git a/arch/arm64/boot/dts/mediatek/mt2712e.dtsi b/arch/arm64/boot/dts/mediatek/mt2712e.dtsi
> index 3232e4e..bf65c92 100644
> --- a/arch/arm64/boot/dts/mediatek/mt2712e.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt2712e.dtsi
> @@ -225,6 +225,15 @@
> (GIC_CPU_MASK_RAW(0x13) | IRQ_TYPE_LEVEL_HIGH)>;
> };
>
> + auxadc: adc@11001000 {
> + compatible = "mediatek,mt2712-auxadc";
> + reg = <0 0x11001000 0 0x1000>;
> + clocks = <&pericfg CLK_PERI_AUXADC>;
> + clock-names = "main";
> + #io-channel-cells = <1>;
> + status = "disabled";
> + };
> +
> uart0: serial@11002000 {
> compatible = "mediatek,mt2712-uart",
> "mediatek,mt6577-uart";

2018-03-19 01:53:28

by Matthias Brugger

[permalink] [raw]
Subject: Re: [PATCH 3/3] arm64: dts: mt2712: Add auxadc device node.



On 10/16/2017 05:09 PM, Matthias Brugger wrote:
>
>
> On 10/13/2017 05:11 PM, Matthias Brugger wrote:
>>
>>
>> On 09/24/2017 05:47 PM, Jonathan Cameron wrote:
>>> On Thu, 21 Sep 2017 09:26:52 +0800
>>> Zhiyong Tao <[email protected]> wrote:
>>>
>>>> Add auxadc device node for MT2712.
>>>>
>>>> Signed-off-by: Zhiyong Tao <[email protected]>
>>>
>>> I've applied the IIO patches to make this work, so assume this will get
>>> picked up in due course.
>>>
>>
>> pushed now to v4.14-next/dts64
>> Thanks.
>>
>
> I realized that this needs the mt2712 clock patches to actually work.
> Dropped for now. Please resubmit as soon as mt2712 clock patches got [1]
> accepted upstream.
>

I think you actually never resubmitted. Anyway I pushed it now to v4.16-next/dts64

Thanks.

> Thanks,
> Matthias
>
> [1] https://lkml.org/lkml/2017/9/19/9