2017-09-23 07:55:59

by Arvind Yadav

Subject: [PATCH v3] staging: greybus: light: Release memory obtained by kasprintf

Free memory region, if gb_lights_channel_config is not successful.

Signed-off-by: Arvind Yadav <[email protected]>
---
changes in v2:
- Subject line changed.
- add kfree in __gb_lights_led_unregister().
- No need to check return value of gb_lights_channel_flash_config().

changes ib v3:
- separate patch for "No need to check return value of
gb_lights_channel_flash_config()".

drivers/staging/greybus/light.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c
index 3f4148c..0f538b8 100644
--- a/drivers/staging/greybus/light.c
+++ b/drivers/staging/greybus/light.c
@@ -925,6 +925,8 @@ static void __gb_lights_led_unregister(struct gb_channel *channel)
return;

led_classdev_unregister(cdev);
+ kfree(cdev->name);
+ cdev->name = NULL;
channel->led = NULL;
}

--
2.7.4

2017-09-25 14:19:27

by Rui Miguel Silva

Subject: Re: [PATCH v3] staging: greybus: light: Release memory obtained by kasprintf

Hi,
On Sat, Sep 23, 2017 at 01:25:30PM +0530, Arvind Yadav wrote:
> Free memory region, if gb_lights_channel_config is not successful.
>
> Signed-off-by: Arvind Yadav <[email protected]>

Thanks for the patch, looks good to me.

Reviewed-by: Rui Miguel Silva <[email protected]>

---
Cheers,
Rui

> ---
> changes in v2:
> - Subject line changed.
> - add kfree in __gb_lights_led_unregister().
> - No need to check return value of gb_lights_channel_flash_config().
>
> changes ib v3:
> - separate patch for "No need to check return value of
> gb_lights_channel_flash_config()".
>
> drivers/staging/greybus/light.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c
> index 3f4148c..0f538b8 100644
> --- a/drivers/staging/greybus/light.c
> +++ b/drivers/staging/greybus/light.c
> @@ -925,6 +925,8 @@ static void __gb_lights_led_unregister(struct gb_channel *channel)
> return;
>
> led_classdev_unregister(cdev);
> + kfree(cdev->name);
> + cdev->name = NULL;
> channel->led = NULL;
> }
>
> --
> 2.7.4
>