2017-09-23 18:15:31

by Shreeya Patel

[permalink] [raw]
Subject: [PATCH] Documentation: DT bindings: Add chip compatible string for audio codec.

This patch adds chip compatible string to remove the warnings
generated by checkpatch that -DT compatible string
"toshiba,apb-dummy-codec" appears un-documented.

Signed-off-by: Shreeya Patel <[email protected]>
---
Documentation/devicetree/bindings/sound/sirf-audio-codec.txt | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/sound/sirf-audio-codec.txt b/Documentation/devicetree/bindings/sound/sirf-audio-codec.txt
index 062f5ec..a61560b 100644
--- a/Documentation/devicetree/bindings/sound/sirf-audio-codec.txt
+++ b/Documentation/devicetree/bindings/sound/sirf-audio-codec.txt
@@ -3,6 +3,7 @@ SiRF internal audio CODEC
Required properties:

- compatible : "sirf,atlas6-audio-codec" or "sirf,prima2-audio-codec"
+ "toshiba,apb-dummy-codec"

- reg : the register address of the device.

@@ -11,7 +12,7 @@ Required properties:
Example:

audiocodec: audiocodec@b0040000 {
- compatible = "sirf,atlas6-audio-codec";
+ compatible = "sirf,atlas6-audio-codec", "toshiba,apb-dummy-codec";
reg = <0xb0040000 0x10000>;
clocks = <&clks 27>;
};
--
2.7.4


2017-09-25 15:58:31

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] Documentation: DT bindings: Add chip compatible string for audio codec.

On Sat, Sep 23, 2017 at 11:45:23PM +0530, Shreeya Patel wrote:
> This patch adds chip compatible string to remove the warnings
> generated by checkpatch that -DT compatible string
> "toshiba,apb-dummy-codec" appears un-documented.

What is this device and why does it make sense to be covered with this
compatible string? The -dummy-codec makes it seem like something that
has no place in a DT at all.

Please use subject lines matching the style for the subsystem. This
makes it easier for people to identify relevant patches.


Attachments:
(No filename) (530.00 B)
signature.asc (488.00 B)
Download all attachments