2017-09-19 07:07:33

by Bhumika Goyal

[permalink] [raw]
Subject: [PATCH] hexagon/time: make rtos_timer_device __initdata

Make this __initdata as it is only modified during the init phase and
after that the structure and its fields are not referenced anywhere.

Signed-off-by: Bhumika Goyal <[email protected]>
---
Hexagon architecture was not found while cross-compiling, so the
file is not compile-tested.

arch/hexagon/kernel/time.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/hexagon/kernel/time.c b/arch/hexagon/kernel/time.c
index 29b1f57..5b5a366 100644
--- a/arch/hexagon/kernel/time.c
+++ b/arch/hexagon/kernel/time.c
@@ -54,7 +54,7 @@
},
};

-static struct platform_device rtos_timer_device = {
+static struct platform_device rtos_timer_device __initdata = {
.name = "rtos_timer",
.id = -1,
.num_resources = ARRAY_SIZE(rtos_timer_resources),
--
1.9.1


2017-09-27 23:23:23

by Richard Kuo

[permalink] [raw]
Subject: Re: [PATCH] hexagon/time: make rtos_timer_device __initdata

On Tue, Sep 19, 2017 at 12:37:21PM +0530, Bhumika Goyal wrote:
> Make this __initdata as it is only modified during the init phase and
> after that the structure and its fields are not referenced anywhere.
>
> Signed-off-by: Bhumika Goyal <[email protected]>
> ---
> Hexagon architecture was not found while cross-compiling, so the
> file is not compile-tested.
>
> arch/hexagon/kernel/time.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Acked-by: Richard Kuo <[email protected]>

--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project