2017-09-20 15:19:36

by Masahiro Yamada

Subject: [PATCH] hexagon: get rid of #include <generated/compile.h>

<generated/compile.h> is created (or updated) when Kbuild descends
into the init/ directory. In parallel building from a pristine
source tree, there is no guarantee <generated/compile.h> exists when
arch/hexagon/kernel/ptrace.c is compiled.

For hexagon architecture, we know UTS_MACHINE is a fixed string
"hexagon", so let's hard-code it, like many architectures do.

Signed-off-by: Masahiro Yamada <[email protected]>
---

arch/hexagon/kernel/ptrace.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/hexagon/kernel/ptrace.c b/arch/hexagon/kernel/ptrace.c
index ecd75e2..fa76493 100644
--- a/arch/hexagon/kernel/ptrace.c
+++ b/arch/hexagon/kernel/ptrace.c
@@ -18,8 +18,6 @@
* 02110-1301, USA.
*/

-#include <generated/compile.h>
-
#include <linux/kernel.h>
#include <linux/sched.h>
#include <linux/sched/task_stack.h>
@@ -180,7 +178,7 @@ static const struct user_regset hexagon_regsets[] = {
};

static const struct user_regset_view hexagon_user_view = {
- .name = UTS_MACHINE,
+ .name = "hexagon",
.e_machine = ELF_ARCH,
.ei_osabi = ELF_OSABI,
.regsets = hexagon_regsets,
--
2.7.4

2017-09-27 23:24:21

by Richard Kuo

Subject: Re: [PATCH] hexagon: get rid of #include <generated/compile.h>

On Thu, Sep 21, 2017 at 12:17:50AM +0900, Masahiro Yamada wrote:
> <generated/compile.h> is created (or updated) when Kbuild descends
> into the init/ directory. In parallel building from a pristine
> source tree, there is no guarantee <generated/compile.h> exists when
> arch/hexagon/kernel/ptrace.c is compiled.
>
> For hexagon architecture, we know UTS_MACHINE is a fixed string
> "hexagon", so let's hard-code it, like many architectures do.
>
> Signed-off-by: Masahiro Yamada <[email protected]>
> ---
>
> arch/hexagon/kernel/ptrace.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>

Acked-by: Richard Kuo <[email protected]>


--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project