2017-10-25 15:24:47

by Jason Gunthorpe

[permalink] [raw]
Subject: Re: [PATCH v2] tpm: use struct tpm_chip for tpm_chip_find_get()

On Wed, Oct 25, 2017 at 01:55:04PM +0200, Jarkko Sakkinen wrote:
> Device number (the character device index) is not a stable identifier
> for a TPM chip. That is the reason why every call site passes
> TPM_ANY_NUM to tpm_chip_find_get().
>
> This commit changes the API in a way that instead a struct tpm_chip
> instance is given and NULL means the default chip. In addition, this
> commit refines the documentation to be up to date with the
> implementation.
>
> Suggested-by: Jason Gunthorpe <[email protected]> (@chip_num -> @chip)
> Signed-off-by: Jarkko Sakkinen <[email protected]>
> v2:
> * Further defined function documentation.
> * Changed @chip_num to @chip instead of removing the parameter as suggested by
> Jason Gunthorpe.

Reviewed-by: Jason Gunthorpe <[email protected]>

Jason

From 1582242864381782214@xxx Wed Oct 25 15:13:02 +0000 2017
X-GM-THRID: 1582230549885813514
X-Gmail-Labels: Inbox,Category Forums