2017-10-26 14:38:33

by Johannes Weiner

[permalink] [raw]
Subject: Re: [PATCH] mm: don't warn about allocations which stall for too long

On Thu, Oct 26, 2017 at 08:28:59PM +0900, Tetsuo Handa wrote:
> [...] it is possible to trigger OOM lockup and/or soft lockups when
> many threads concurrently called warn_alloc() (in order to warn
> about memory allocation stalls) due to current implementation of
> printk(), and it is difficult to obtain useful information due to
> limitation of synchronous warning approach.
>
> [...]
>
> Signed-off-by: Tetsuo Handa <[email protected]>
> Reported-by: Cong Wang <[email protected]>
> Reported-by: yuwang.yuwang <[email protected]>
> Reported-by: Johannes Weiner <[email protected]>
> Cc: Michal Hocko <[email protected]>
> Cc: Vlastimil Babka <[email protected]>
> Cc: Mel Gorman <[email protected]>
> Cc: Dave Hansen <[email protected]>
> Cc: Sergey Senozhatsky <[email protected]>
> Cc: Petr Mladek <[email protected]>

It would have been nice to be able to fix it instead, because there is
value in having the lockup detection. But it's true that it currently
causes more problems than it solves. Back to the drawing board for now.

Acked-by: Johannes Weiner <[email protected]>

Thanks Tetsuo!

From 1582320188643777408@xxx Thu Oct 26 11:42:04 +0000 2017
X-GM-THRID: 1582319483972251768
X-Gmail-Labels: Inbox,Category Forums