2017-11-03 14:52:41

by Gustavo A. R. Silva

[permalink] [raw]
Subject: [PATCH] watchdog: pcwd_pci: mark expected switch fall-through

In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Notice that in this particular case I replaced "Fall" with a proper
"fall through" comment, which is what GCC is expecting to find.

Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
drivers/watchdog/pcwd_pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/watchdog/pcwd_pci.c b/drivers/watchdog/pcwd_pci.c
index c0d07ee..c882252 100644
--- a/drivers/watchdog/pcwd_pci.c
+++ b/drivers/watchdog/pcwd_pci.c
@@ -545,7 +545,7 @@ static long pcipcwd_ioctl(struct file *file, unsigned int cmd,
return -EINVAL;

pcipcwd_keepalive();
- /* Fall */
+ /* fall through */
}

case WDIOC_GETTIMEOUT:
--
2.7.4


From 1583077425853309207@xxx Fri Nov 03 20:18:01 +0000 2017
X-GM-THRID: 1583077425853309207
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread