2017-11-03 14:56:24

by Gustavo A. R. Silva

[permalink] [raw]
Subject: [PATCH] watchdog: pcwd_usb: mark expected switch fall-through

In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Notice that in this particular case I replaced "Fall" with a proper
"fall through" comment, which is what GCC is expecting to find.

Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
drivers/watchdog/pcwd_usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/watchdog/pcwd_usb.c b/drivers/watchdog/pcwd_usb.c
index b9e376c..47fe4c5 100644
--- a/drivers/watchdog/pcwd_usb.c
+++ b/drivers/watchdog/pcwd_usb.c
@@ -456,8 +456,8 @@ static long usb_pcwd_ioctl(struct file *file, unsigned int cmd,
return -EINVAL;

usb_pcwd_keepalive(usb_pcwd_device);
- /* Fall */
}
+ /* fall through */

case WDIOC_GETTIMEOUT:
return put_user(heartbeat, p);
--
2.7.4


From 1582903359311279070@xxx Wed Nov 01 22:11:19 +0000 2017
X-GM-THRID: 1582903359311279070
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread