Quoting Han Xu <[email protected]>:
> ________________________________________
> From: Gustavo A. R. Silva <[email protected]>
> Sent: Friday, November 3, 2017 3:31 PM
> To: Han Xu; Boris Brezillon; Richard Weinberger; David Woodhouse;
> Brian Norris; Marek Vasut; Cyrille Pitchen
> Cc: [email protected]; [email protected];
> Gustavo A. R. Silva
> Subject: [PATCH] mtd: nand: gpmi: replace _manual_ swap with swap macro
>
> Make use of the swap macro and remove unnecessary variables swap.
> This makes the code easier to read and maintain.
>
> This code was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <[email protected]>
> ---
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 16 ++++------------
> 1 file changed, 4 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> index 50f8d4a..9e365d4 100644
> --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> @@ -1487,12 +1487,8 @@ static int gpmi_ecc_read_page_raw(struct
> mtd_info *mtd,
> * See the layout description for a detailed explanation on why this
> * is needed.
> */
> - if (this->swap_block_mark) {
> - u8 swap = tmp_buf[0];
> -
> - tmp_buf[0] = tmp_buf[mtd->writesize];
> - tmp_buf[mtd->writesize] = swap;
> - }
> + if (this->swap_block_mark)
> + swap(tmp_buf[0], tmp_buf[mtd->writesize]);
>
> /*
> * Copy the metadata section into the oob buffer (this section is
> @@ -1615,12 +1611,8 @@ static int gpmi_ecc_write_page_raw(struct
> mtd_info *mtd,
> * See the layout description for a detailed explanation on why this
> * is needed.
> */
> - if (this->swap_block_mark) {
> - u8 swap = tmp_buf[0];
> -
> - tmp_buf[0] = tmp_buf[mtd->writesize];
> - tmp_buf[mtd->writesize] = swap;
> - }
> + if (this->swap_block_mark)
> + swap(tmp_buf[0], tmp_buf[mtd->writesize]);
>
> chip->write_buf(mtd, tmp_buf, mtd->writesize + mtd->oobsize);
>
> Acked-by: Han Xu <[email protected]>
>
Thank you, Han.
--
Gustavo A. R. Silva
From 1583078820639455545@xxx Fri Nov 03 20:40:12 +0000 2017
X-GM-THRID: 1583078363686038112
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread