Hi all,
After merging the tip tree, today's linux-next build (htmldocs) produced
these warnings:
Documentation/virt/coco/sev-guest.rst:75: WARNING: Inline emphasis start-string without end-string.
Documentation/virt/coco/sev-guest.rst:78: WARNING: Inline emphasis start-string without end-string.
Documentation/virt/coco/sev-guest.rst:81: WARNING: Inline emphasis start-string without end-string.
Documentation/virt/coco/sev-guest.rst:83: WARNING: Definition list ends without a blank line; unexpected unindent.
Introduced by commit
f5db8841ebe5 ("crypto: ccp: Add the SNP_PLATFORM_STATUS command")
--
Cheers,
Stephen Rothwell
Hi all,
On Thu, 2 Nov 2017 13:53:51 +1100 Stephen Rothwell <[email protected]> wrote:
>
> After merging the tip tree, today's linux-next build (x86_64 allmodconfig)
> produced these warnings:
>
> net/dccp/probe.c: In function 'dccpprobe_init':
> net/dccp/probe.c:166:2: warning: 'register_jprobe' is deprecated [-Wdeprecated-declarations]
> ret = register_jprobe(&dccp_send_probe);
> ^
> In file included from net/dccp/probe.c:26:0:
> include/linux/kprobes.h:471:32: note: declared here
> static inline int __deprecated register_jprobe(struct jprobe *p)
> ^
> net/dccp/probe.c:170:4: warning: 'register_jprobe' is deprecated [-Wdeprecated-declarations]
> ret = register_jprobe(&dccp_send_probe);
> ^
> In file included from net/dccp/probe.c:26:0:
> include/linux/kprobes.h:471:32: note: declared here
> static inline int __deprecated register_jprobe(struct jprobe *p)
> ^
> net/dccp/probe.c: In function 'dccpprobe_exit':
> net/dccp/probe.c:190:2: warning: 'unregister_jprobe' is deprecated [-Wdeprecated-declarations]
> unregister_jprobe(&dccp_send_probe);
> ^
> In file included from net/dccp/probe.c:26:0:
> include/linux/kprobes.h:479:33: note: declared here
> static inline void __deprecated unregister_jprobe(struct jprobe *p)
> ^
> net/ipv4/tcp_probe.c: In function 'tcpprobe_init':
> net/ipv4/tcp_probe.c:280:2: warning: 'register_jprobe' is deprecated [-Wdeprecated-declarations]
> ret = register_jprobe(&tcp_jprobe);
> ^
> In file included from net/ipv4/tcp_probe.c:24:0:
> include/linux/kprobes.h:471:32: note: declared here
> static inline int __deprecated register_jprobe(struct jprobe *p)
> ^
> net/ipv4/tcp_probe.c: In function 'tcpprobe_exit':
> net/ipv4/tcp_probe.c:298:2: warning: 'unregister_jprobe' is deprecated [-Wdeprecated-declarations]
> unregister_jprobe(&tcp_jprobe);
> ^
> In file included from net/ipv4/tcp_probe.c:24:0:
> include/linux/kprobes.h:479:33: note: declared here
> static inline void __deprecated unregister_jprobe(struct jprobe *p)
> ^
> net/sctp/probe.c: In function 'sctp_setup_jprobe':
> net/sctp/probe.c:189:2: warning: 'register_jprobe' is deprecated [-Wdeprecated-declarations]
> int ret = register_jprobe(&sctp_recv_probe);
> ^
> In file included from net/sctp/probe.c:28:0:
> include/linux/kprobes.h:471:32: note: declared here
> static inline int __deprecated register_jprobe(struct jprobe *p)
> ^
> net/sctp/probe.c:194:3: warning: 'register_jprobe' is deprecated [-Wdeprecated-declarations]
> ret = register_jprobe(&sctp_recv_probe);
> ^
> In file included from net/sctp/probe.c:28:0:
> include/linux/kprobes.h:471:32: note: declared here
> static inline int __deprecated register_jprobe(struct jprobe *p)
> ^
> net/sctp/probe.c: In function 'sctpprobe_exit':
> net/sctp/probe.c:240:2: warning: 'unregister_jprobe' is deprecated [-Wdeprecated-declarations]
> unregister_jprobe(&sctp_recv_probe);
> ^
> In file included from net/sctp/probe.c:28:0:
> include/linux/kprobes.h:479:33: note: declared here
> static inline void __deprecated unregister_jprobe(struct jprobe *p)
> ^
>
> Introduced by commit
>
> 590c84593045 ("kprobes: Disable the jprobes APIs")
>
> These days we normally don't deprecate things, just remove them. But we
> do that *after* fixing up all the usages in the tree, please.
Just a reminder that I am still getting these warnings.
--
Cheers,
Stephen Rothwell
From 1583137790092094345@xxx Sat Nov 04 12:17:29 +0000 2017
X-GM-THRID: 1582921229079518323
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread
On Sat, 4 Nov 2017 09:01:34 +0100
Ingo Molnar <[email protected]> wrote:
>
> * Masami Hiramatsu <[email protected]> wrote:
>
> > > net/sctp/probe.c: In function 'sctpprobe_exit':
> > > net/sctp/probe.c:240:2: warning: 'unregister_jprobe' is deprecated [-Wdeprecated-declarations]
> > > unregister_jprobe(&sctp_recv_probe);
> > > ^
> > > In file included from net/sctp/probe.c:28:0:
> > > include/linux/kprobes.h:479:33: note: declared here
> > > static inline void __deprecated unregister_jprobe(struct jprobe *p)
> > > ^
> > >
> > > Introduced by commit
> > >
> > > 590c84593045 ("kprobes: Disable the jprobes APIs")
> > >
> > > These days we normally don't deprecate things, just remove them. But we
> > > do that *after* fixing up all the usages in the tree, please.
> >
> > OK, should I remove __deprecated or revert above patch?
> > I pinged such users but no response. I can just rewrite it but not sure they can reply.
>
> Ideal would be to just fix all these places: convert code where the facility
> appears to be actively used, remove code where it looks unused. If maintainers
> don't reply, I can apply them to a separate branch in -tip.
Thanks, that will help me.
>
> For example I'm pretty sure we can just remove the jprobes usage in SCTP.
Actually TCP and DCCP jprobes usages are similar to that SCTP usage
(maybe derived from TCP one). For those usages, we can not replace
it with kprobe/ftrace because it depends on the arguments of target funcs.
For such use-cases, we have 3 options;
- Remove entirely feature if possible (like no more used).
- Replace it with trace-events, and handle the event from kernel as sched tracer does.
- Just introduce trace-events, remove usage, and trace it via ftrace or perf.
At a glance, all network probes are just used for printing out the event,
so we can just introduce trace-events and remove usage. I will try it.
Thank you,
--
Masami Hiramatsu <[email protected]>
From 1583121749297802158@xxx Sat Nov 04 08:02:32 +0000 2017
X-GM-THRID: 1582921229079518323
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread
* Masami Hiramatsu <[email protected]> wrote:
> > net/sctp/probe.c: In function 'sctpprobe_exit':
> > net/sctp/probe.c:240:2: warning: 'unregister_jprobe' is deprecated [-Wdeprecated-declarations]
> > unregister_jprobe(&sctp_recv_probe);
> > ^
> > In file included from net/sctp/probe.c:28:0:
> > include/linux/kprobes.h:479:33: note: declared here
> > static inline void __deprecated unregister_jprobe(struct jprobe *p)
> > ^
> >
> > Introduced by commit
> >
> > 590c84593045 ("kprobes: Disable the jprobes APIs")
> >
> > These days we normally don't deprecate things, just remove them. But we
> > do that *after* fixing up all the usages in the tree, please.
>
> OK, should I remove __deprecated or revert above patch?
> I pinged such users but no response. I can just rewrite it but not sure they can reply.
Ideal would be to just fix all these places: convert code where the facility
appears to be actively used, remove code where it looks unused. If maintainers
don't reply, I can apply them to a separate branch in -tip.
For example I'm pretty sure we can just remove the jprobes usage in SCTP.
Thanks,
Ingo
From 1583080168191860330@xxx Fri Nov 03 21:01:37 +0000 2017
X-GM-THRID: 1582921229079518323
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread
On Thu, 2 Nov 2017 13:53:51 +1100
Stephen Rothwell <[email protected]> wrote:
> Hi all,
>
> After merging the tip tree, today's linux-next build (x86_64 allmodconfig)
> produced these warnings:
>
> net/dccp/probe.c: In function 'dccpprobe_init':
> net/dccp/probe.c:166:2: warning: 'register_jprobe' is deprecated [-Wdeprecated-declarations]
> ret = register_jprobe(&dccp_send_probe);
> ^
> In file included from net/dccp/probe.c:26:0:
> include/linux/kprobes.h:471:32: note: declared here
> static inline int __deprecated register_jprobe(struct jprobe *p)
> ^
> net/dccp/probe.c:170:4: warning: 'register_jprobe' is deprecated [-Wdeprecated-declarations]
> ret = register_jprobe(&dccp_send_probe);
> ^
> In file included from net/dccp/probe.c:26:0:
> include/linux/kprobes.h:471:32: note: declared here
> static inline int __deprecated register_jprobe(struct jprobe *p)
> ^
> net/dccp/probe.c: In function 'dccpprobe_exit':
> net/dccp/probe.c:190:2: warning: 'unregister_jprobe' is deprecated [-Wdeprecated-declarations]
> unregister_jprobe(&dccp_send_probe);
> ^
> In file included from net/dccp/probe.c:26:0:
> include/linux/kprobes.h:479:33: note: declared here
> static inline void __deprecated unregister_jprobe(struct jprobe *p)
> ^
> net/ipv4/tcp_probe.c: In function 'tcpprobe_init':
> net/ipv4/tcp_probe.c:280:2: warning: 'register_jprobe' is deprecated [-Wdeprecated-declarations]
> ret = register_jprobe(&tcp_jprobe);
> ^
> In file included from net/ipv4/tcp_probe.c:24:0:
> include/linux/kprobes.h:471:32: note: declared here
> static inline int __deprecated register_jprobe(struct jprobe *p)
> ^
> net/ipv4/tcp_probe.c: In function 'tcpprobe_exit':
> net/ipv4/tcp_probe.c:298:2: warning: 'unregister_jprobe' is deprecated [-Wdeprecated-declarations]
> unregister_jprobe(&tcp_jprobe);
> ^
> In file included from net/ipv4/tcp_probe.c:24:0:
> include/linux/kprobes.h:479:33: note: declared here
> static inline void __deprecated unregister_jprobe(struct jprobe *p)
> ^
> net/sctp/probe.c: In function 'sctp_setup_jprobe':
> net/sctp/probe.c:189:2: warning: 'register_jprobe' is deprecated [-Wdeprecated-declarations]
> int ret = register_jprobe(&sctp_recv_probe);
> ^
> In file included from net/sctp/probe.c:28:0:
> include/linux/kprobes.h:471:32: note: declared here
> static inline int __deprecated register_jprobe(struct jprobe *p)
> ^
> net/sctp/probe.c:194:3: warning: 'register_jprobe' is deprecated [-Wdeprecated-declarations]
> ret = register_jprobe(&sctp_recv_probe);
> ^
> In file included from net/sctp/probe.c:28:0:
> include/linux/kprobes.h:471:32: note: declared here
> static inline int __deprecated register_jprobe(struct jprobe *p)
> ^
> net/sctp/probe.c: In function 'sctpprobe_exit':
> net/sctp/probe.c:240:2: warning: 'unregister_jprobe' is deprecated [-Wdeprecated-declarations]
> unregister_jprobe(&sctp_recv_probe);
> ^
> In file included from net/sctp/probe.c:28:0:
> include/linux/kprobes.h:479:33: note: declared here
> static inline void __deprecated unregister_jprobe(struct jprobe *p)
> ^
>
> Introduced by commit
>
> 590c84593045 ("kprobes: Disable the jprobes APIs")
>
> These days we normally don't deprecate things, just remove them. But we
> do that *after* fixing up all the usages in the tree, please.
OK, should I remove __deprecated or revert above patch?
I pinged such users but no response. I can just rewrite it but not sure they can reply.
Thank you,
>
> --
> Cheers,
> Stephen Rothwell
--
Masami Hiramatsu <[email protected]>
From 1582921229079518323@xxx Thu Nov 02 02:55:21 +0000 2017
X-GM-THRID: 1582921229079518323
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread