2017-11-05 04:53:49

by Gustavo A. R. Silva

[permalink] [raw]
Subject: [PATCH] thunderbolt: tb: fix use after free in tb_activate_pcie_devices

Add a ̣̣continue statement in order to avoid using a previously
free'd pointer tunnel in list_add.

Addresses-Coverity-ID: 1415336
Fixes: 9d3cce0b6136 ("thunderbolt: Introduce thunderbolt bus and connection manager")
Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
drivers/thunderbolt/tb.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/thunderbolt/tb.c b/drivers/thunderbolt/tb.c
index d674e06..1424581 100644
--- a/drivers/thunderbolt/tb.c
+++ b/drivers/thunderbolt/tb.c
@@ -225,6 +225,7 @@ static void tb_activate_pcie_devices(struct tb *tb)
tb_port_info(up_port,
"PCIe tunnel activation failed, aborting\n");
tb_pci_free(tunnel);
+ continue;
}

list_add(&tunnel->list, &tcm->tunnel_list);
--
2.7.4


From 1583316363597433510@xxx Mon Nov 06 11:35:50 +0000 2017
X-GM-THRID: 1583307971654292943
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread