2017-11-06 11:28:12

by Himanshu Jha

[permalink] [raw]
Subject: Re: [PATCH] freezer: Fix typo in commnent to function freezable_schedule_timeout()

On Sat, Nov 04, 2017 at 11:02:56PM +0100, Pavel Machek wrote:
> On Sun 2017-11-05 03:27:32, Himanshu Jha wrote:
> > Signed-off-by: Himanshu Jha <[email protected]>
>
> ACK.
>
> But note you have typo in the subject ;-).

Oops!
Do I need to send v2 with correct subject ?

> Plus this kind of bug is usually called thinko.
> Pavel
>
>
> > diff --git a/include/linux/freezer.h b/include/linux/freezer.h
> > index 3995df1..21f5aa0 100644
> > --- a/include/linux/freezer.h
> > +++ b/include/linux/freezer.h
> > @@ -182,7 +182,7 @@ static inline void freezable_schedule_unsafe(void)
> > }
> >
> > /*
> > - * Like freezable_schedule_timeout(), but should not block the freezer. Do not
> > + * Like schedule_timeout(), but should not block the freezer. Do not
> > * call this with locks held.
> > */
> > static inline long freezable_schedule_timeout(long timeout)
>
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Thanks
Himanshu Jha


From 1583174676627190323@xxx Sat Nov 04 22:03:47 +0000 2017
X-GM-THRID: 1583174360594116469
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread