2017-11-08 09:48:39

by Tobias Klauser

[permalink] [raw]
Subject: Re: [PATCH 03/31] nds32: Support early_printk

On 2017-11-08 at 06:54:51 +0100, Greentime Hu <[email protected]> wrote:
> From: Greentime Hu <[email protected]>
>
> Signed-off-by: Rick Chen <[email protected]>
> Signed-off-by: Greentime Hu <[email protected]>
> ---
> arch/nds32/kernel/early_printk.c | 124 ++++++++++++++++++++++++++++++++++++++
> 1 file changed, 124 insertions(+)
> create mode 100644 arch/nds32/kernel/early_printk.c
>
> diff --git a/arch/nds32/kernel/early_printk.c b/arch/nds32/kernel/early_printk.c
> new file mode 100644
> index 0000000..269c3cd
> --- /dev/null
> +++ b/arch/nds32/kernel/early_printk.c

Could be implemented using earlycon (the 8250 drivers already supports
it) instead of duplicating functionality in arch/nds32? See e.g. the
nios2 port for how this could be done, specifically commit e118c3fec9c0
("nios2: remove custom early console implementation").

From 1583483512506029402@xxx Wed Nov 08 07:52:36 +0000 2017
X-GM-THRID: 1583483512506029402
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread