2017-11-08 15:51:05

by Vivien Didelot

[permalink] [raw]
Subject: [PATCH net] net: dsa: return after vlan prepare phase

The current code does not return after successfully preparing the VLAN
addition on every ports member of a it. Fix this.

Fixes: 1ca4aa9cd4cc ("net: dsa: check VLAN capability of every switch")
Signed-off-by: Vivien Didelot <[email protected]>
---
net/dsa/switch.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/net/dsa/switch.c b/net/dsa/switch.c
index 73746fa148f1..1e2929f4290a 100644
--- a/net/dsa/switch.c
+++ b/net/dsa/switch.c
@@ -182,6 +182,8 @@ static int dsa_switch_vlan_add(struct dsa_switch *ds,
if (err)
return err;
}
+
+ return 0;
}

for_each_set_bit(port, members, ds->num_ports)
--
2.15.0


From 1583679593782025490@xxx Fri Nov 10 11:49:14 +0000 2017
X-GM-THRID: 1581653232642378758
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread