2017-11-10 00:13:58

by Bjorn Andersson

Subject: Re: [PATCH v5 0/7] PM / devfreq: Use OPP interface to handle the frequency

On Thu 09 Nov 15:56 PST 2017, MyungJoo Ham wrote:

> > On Sun, Oct 22, 2017 at 6:32 PM, Chanwoo Choi <[email protected]> wrote:
> > > These patches makes the devfreq to use the OPP interface and clean-up codes.
> > >
> >
> > Hi Chanwoo,
> >
> > This patch series breaks UFS support on modern Qualcomm platforms
> > (e.g. MSM8996).
>
> Could you please show us the code location of it?�
>

The driver is drivers/scsi/ufs/ufshcd.c function ufshcd_probe_hba()
calls devm_devfreq_add_device() without there being an opp table
associated with hba->dev. This used to return fine and
ufshcd_devfreq_target() was called with *freq = UINT_MAX.

Unfortunately the driver seems to be designed in such a way that without
a call to ufshcd_devfreq_target() with *freq 0 or UINT_MAX some clock is
left off, causing my board to reboot; so there's unfortunately a few
levels of issues to fix here.

Regards,
Bjorn

From 1583634836793899106@xxx Thu Nov 09 23:57:50 +0000 2017
X-GM-THRID: 1582010376374599170
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread

2017-11-09 23:57:50

by MyungJoo Ham

Subject: RE: Re: [PATCH v5 0/7] PM / devfreq: Use OPP interface to handle the frequency

> On Sun, Oct 22, 2017 at 6:32 PM, Chanwoo Choi <[email protected]> wrote:
> > These patches makes the devfreq to use the OPP interface and clean-up codes.
> >
>
> Hi Chanwoo,
>
> This patch series breaks UFS support on modern Qualcomm platforms
> (e.g. MSM8996).

Could you please show us the code location of it? 

Cheers,
MyungJoo 
 
--
MyungJoo Ham (함명주), Ph.D.
AI-3-Lab, AI Team, Samsung Research.
Samsung Electronics
Cell: +82-10-6714-2858

From 1583341811312910433@xxx Mon Nov 06 18:20:19 +0000 2017
X-GM-THRID: 1582010376374599170
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread