2017-11-12 08:29:34

by Gustavo A. R. Silva

[permalink] [raw]
Subject: [PATCH] PM / devfreq: Remove unnecessary NULL check before kfree

NULL check before freeing functions like kfree is not needed.

This issue was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
drivers/devfreq/devfreq.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
index 78fb496..21164a9 100644
--- a/drivers/devfreq/devfreq.c
+++ b/drivers/devfreq/devfreq.c
@@ -672,8 +672,7 @@ struct devfreq *devfreq_add_device(struct device *dev,

device_unregister(&devfreq->dev);
err_dev:
- if (devfreq)
- kfree(devfreq);
+ kfree(devfreq);
err_out:
return ERR_PTR(err);
}
--
2.7.4


From 1583798898538225340@xxx Sat Nov 11 19:25:31 +0000 2017
X-GM-THRID: 1583798898538225340
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread