2017-11-12 08:36:06

by Gustavo A. R. Silva

[permalink] [raw]
Subject: [PATCH] scsi: aic7xxx_core: remove unnecessary null check before kfree

NULL check before freeing functions like kfree is not needed.

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
drivers/scsi/aic7xxx/aic7xxx_core.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/scsi/aic7xxx/aic7xxx_core.c b/drivers/scsi/aic7xxx/aic7xxx_core.c
index 6612ff3..8d96e11 100644
--- a/drivers/scsi/aic7xxx/aic7xxx_core.c
+++ b/drivers/scsi/aic7xxx/aic7xxx_core.c
@@ -4549,10 +4549,8 @@ ahc_free(struct ahc_softc *ahc)
kfree(ahc->black_hole);
}
#endif
- if (ahc->name != NULL)
- kfree(ahc->name);
- if (ahc->seep_config != NULL)
- kfree(ahc->seep_config);
+ kfree(ahc->name);
+ kfree(ahc->seep_config);
#ifndef __FreeBSD__
kfree(ahc);
#endif
--
2.7.4


From 1583748971332159214@xxx Sat Nov 11 06:11:57 +0000 2017
X-GM-THRID: 1583483248399711624
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread