2017-11-12 13:14:37

by Gabriel L. Somlo

[permalink] [raw]
Subject: Re: [PATCH v4 1/5] fw_cfg: fix the command line module name

On Tue, Oct 31, 2017 at 04:19:34PM +0100, Marc-Andr� Lureau wrote:
> Signed-off-by: Marc-Andr� Lureau <[email protected]>

Acked-by: Gabriel Somlo <[email protected]>

> ---
> drivers/firmware/qemu_fw_cfg.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c
> index 0e2011636fbb..5cfe39f7a45f 100644
> --- a/drivers/firmware/qemu_fw_cfg.c
> +++ b/drivers/firmware/qemu_fw_cfg.c
> @@ -10,9 +10,9 @@
> * and select subsets of aarch64), a Device Tree node (on arm), or using
> * a kernel module (or command line) parameter with the following syntax:
> *
> - * [fw_cfg.]ioport=<size>@<base>[:<ctrl_off>:<data_off>]
> + * [qemu_fw_cfg.]ioport=<size>@<base>[:<ctrl_off>:<data_off>]
> * or
> - * [fw_cfg.]mmio=<size>@<base>[:<ctrl_off>:<data_off>]
> + * [qemu_fw_cfg.]mmio=<size>@<base>[:<ctrl_off>:<data_off>]
> *
> * where:
> * <size> := size of ioport or mmio range
> @@ -21,9 +21,9 @@
> * <data_off> := (optional) offset of data register
> *
> * e.g.:
> - * fw_cfg.ioport=2@0x510:0:1 (the default on x86)
> + * qemu_fw_cfg.ioport=2@0x510:0:1 (the default on x86)
> * or
> - * fw_cfg.mmio=0xA@0x9020000:8:0 (the default on arm)
> + * qemu_fw_cfg.mmio=0xA@0x9020000:8:0 (the default on arm)
> */
>
> #include <linux/module.h>
> --
> 2.15.0.rc0.40.gaefcc5f6f
>

From 1582786975308132650@xxx Tue Oct 31 15:21:26 +0000 2017
X-GM-THRID: 1582786975308132650
X-Gmail-Labels: Inbox,Category Forums