2017-11-13 18:23:05

by James Hogan

[permalink] [raw]
Subject: Re: [PATCH] MIPS: Add iomem resource for kernel bss section.

On Thu, Oct 12, 2017 at 12:50:34PM -0700, David Daney wrote:
> The kexec/kdump tools need to know where the .bss is so it can be
> included in the core dump. This allows vmcore-dmesg to have access to
> the dmesg buffers of the crashed kernel as well as allowing the
> debugger to examine variables in the bss section.
>
> Add a request for the bss resource in addition to the already
> requested code and data sections.
>
> Signed-off-by: David Daney <[email protected]>

Thanks, applied.

Cheers
James

> ---
> arch/mips/kernel/setup.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c
> index fe39397..702c678 100644
> --- a/arch/mips/kernel/setup.c
> +++ b/arch/mips/kernel/setup.c
> @@ -80,6 +80,7 @@ EXPORT_SYMBOL(mips_io_port_base);
>
> static struct resource code_resource = { .name = "Kernel code", };
> static struct resource data_resource = { .name = "Kernel data", };
> +static struct resource bss_resource = { .name = "Kernel bss", };
>
> static void *detect_magic __initdata = detect_memory_region;
>
> @@ -927,6 +928,8 @@ static void __init resource_init(void)
> code_resource.end = __pa_symbol(&_etext) - 1;
> data_resource.start = __pa_symbol(&_etext);
> data_resource.end = __pa_symbol(&_edata) - 1;
> + bss_resource.start = __pa_symbol(&__bss_start);
> + bss_resource.end = __pa_symbol(&__bss_stop) - 1;
>
> for (i = 0; i < boot_mem_map.nr_map; i++) {
> struct resource *res;
> @@ -966,6 +969,7 @@ static void __init resource_init(void)
> */
> request_resource(res, &code_resource);
> request_resource(res, &data_resource);
> + request_resource(res, &bss_resource);
> request_crashkernel(res);
> }
> }
> --
> 2.9.5
>

From 1581082712143982461@xxx Thu Oct 12 19:52:54 +0000 2017
X-GM-THRID: 1581082712143982461
X-Gmail-Labels: Inbox,Category Forums