2017-11-14 09:49:31

by Yury Norov

[permalink] [raw]
Subject: Re: [PATCH] lib: use correct format string for find-bit tests

On Mon, Nov 13, 2017 at 02:55:45PM +0100, Arnd Bergmann wrote:
> The cycles_t definition is architecture specific, which causes
> a link error on all architectures that use a 'long long' or 'int'
> type for it:
>
> lib/test_find_bit.c: In function 'test_find_last_bit':
> include/linux/kern_levels.h:5:18: error: format '%ld' expects argument of type 'long int', but argument 2 has type 'cycles_t {aka long long unsigned int}' [-Werror=format=]
>
> This adds an explicit cast to 'u64' for it, which lets us use
> '%llu' everywhere.
>
> Fixes: 09588b1f1d58 ("lib: test module for find_*_bit() functions")
> Signed-off-by: Arnd Bergmann <[email protected]>

Hi Arnd,

patch looks OK. Thank you.

Acked-by: Yury Norov <[email protected]>

From 1583959532832146602@xxx Mon Nov 13 13:58:44 +0000 2017
X-GM-THRID: 1583959532832146602
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread