2017-11-16 22:30:54

by Johannes Weiner

[permalink] [raw]
Subject: Re: [PATCH 1/2] mm,vmscan: Kill global shrinker lock.

On Wed, Nov 15, 2017 at 09:56:02AM +0900, Minchan Kim wrote:
> @@ -498,6 +498,14 @@ static unsigned long shrink_slab(gfp_t gfp_mask, int nid,
> sc.nid = 0;
>
> freed += do_shrink_slab(&sc, shrinker, nr_scanned, nr_eligible);
> + /*
> + * bail out if someone want to register a new shrinker to prevent
> + * long time stall by parallel ongoing shrinking.
> + */
> + if (rwsem_is_contended(&shrinker_rwsem)) {
> + freed = 1;
> + break;
> + }
> }

When you send the formal version, please include

Acked-by: Johannes Weiner <[email protected]>

From 1584231271087837739@xxx Thu Nov 16 13:57:54 +0000 2017
X-GM-THRID: 1583988486620709897
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread