2017-11-17 22:06:27

by Laurentiu Tudor

[permalink] [raw]
Subject: [PATCH 02/10] staging: fsl-mc/dpio: remove incomplete refcount implementation

From: Laurentiu Tudor <[email protected]>

There's an unfinished implementation of reference counting for dpaa2_io
structure using atomics. Since it's unused lets remove it for now and,
if needed at a later time, make use of krefs instead of rolling our
own refcounting.

Signed-off-by: Laurentiu Tudor <[email protected]>
---
drivers/staging/fsl-mc/bus/dpio/dpio-service.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/drivers/staging/fsl-mc/bus/dpio/dpio-service.c b/drivers/staging/fsl-mc/bus/dpio/dpio-service.c
index a609ec8..591d8b7 100644
--- a/drivers/staging/fsl-mc/bus/dpio/dpio-service.c
+++ b/drivers/staging/fsl-mc/bus/dpio/dpio-service.c
@@ -43,7 +43,6 @@
#include "qbman-portal.h"

struct dpaa2_io {
- atomic_t refs;
struct dpaa2_io_desc dpio_desc;
struct qbman_swp_desc swp_desc;
struct qbman_swp *swp;
@@ -126,7 +125,6 @@ struct dpaa2_io *dpaa2_io_create(const struct dpaa2_io_desc *desc)
return NULL;
}

- atomic_set(&obj->refs, 1);
obj->dpio_desc = *desc;
obj->swp_desc.cena_bar = obj->dpio_desc.regs_cena;
obj->swp_desc.cinh_bar = obj->dpio_desc.regs_cinh;
@@ -171,8 +169,6 @@ EXPORT_SYMBOL(dpaa2_io_create);
*/
void dpaa2_io_down(struct dpaa2_io *d)
{
- if (!atomic_dec_and_test(&d->refs))
- return;
kfree(d);
}
EXPORT_SYMBOL(dpaa2_io_down);
--
2.9.4


From 1584372827118841055@xxx Sat Nov 18 03:27:52 +0000 2017
X-GM-THRID: 1584372827118841055
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread