2017-11-17 20:46:19

by Lukas Wunner

[permalink] [raw]
Subject: Re: [git pull] drm for v4.15

On Fri, Nov 17, 2017 at 08:57:53AM -0800, Linus Torvalds wrote:
> On Fri, Nov 17, 2017 at 4:51 AM, Nicolai H�hnle <[email protected]> wrote:
> To see the effects of this, I picked something at random from one of
> those huge AMD header files.
>
> I swear. It was entirely at random, and the first thing I picked. Do this:
>
> git grep PCIE_UNCORR_ERR_MASK

Oh that looks familiar, it's the Uncorrectable Error Mask Register
(PCIe Base Spec r2.1 page 558). We already have those definitions
in the tree in include/uapi/linux/pci_regs.h:

git grep PCI_ERR_UNC_


> and tell me that there isn't any room for making these things smarter.

... or deduplicate them. :-)

Lukas

From 1584347411440311118@xxx Fri Nov 17 20:43:54 +0000 2017
X-GM-THRID: 1584194585945726173
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread