2017-11-20 17:23:39

by Gustavo A. R. Silva

[permalink] [raw]
Subject: [PATCH] watchdog: ib700wdt: mark expected switch fall-through

In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Notice that in this particular case I replaced "Fall" with a proper
"fall through" comment, which is what GCC is expecting to find.

Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
drivers/watchdog/ib700wdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/watchdog/ib700wdt.c b/drivers/watchdog/ib700wdt.c
index f2e4e1e..cc26228 100644
--- a/drivers/watchdog/ib700wdt.c
+++ b/drivers/watchdog/ib700wdt.c
@@ -218,7 +218,7 @@ static long ibwdt_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
if (ibwdt_set_heartbeat(new_margin))
return -EINVAL;
ibwdt_ping();
- /* Fall */
+ /* fall through */

case WDIOC_GETTIMEOUT:
return put_user(timeout, p);
--
2.7.4


From 1584150437651407489@xxx Wed Nov 15 16:33:05 +0000 2017
X-GM-THRID: 1584150437651407489
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread