2017-11-20 20:09:35

by Luc Van Oostenryck

[permalink] [raw]
Subject: Re: [PATCH 2/7] kbuild: Add P= command line flag to run checkpatch

On Mon, Nov 20, 2017 at 12:48:35PM -0700, Jim Davis wrote:
>
> I'd be nice if people could just specify CHECK and CHECKFLAGS to run
> their favorite checker, but currently CHECKFLAGS seems hardwired for
> running sparse. So something liike
>
> make C=1 CHECK="scripts/checkpatch.pl" CHECKFLAGS="--quiet --file"
>
> fails when checkpatch is passed lots of arguments like -D__linux__
> -Dlinux -D__STDC__ . A little shell wrapper to grab the last argument
> in that long list is a workaround, but perhaps CHECKFLAGS should be
> made less sparse-specific?

It should be noted though that CHECKFLAGS contains very very few
sparse specific things. It's mainly flags for the compiler
coming from KBUILD_CFLAGS (which of course, sparse needs to
do its job properly).

-- Luc Van Oostenryck

From 1584615804644202375@xxx Mon Nov 20 19:49:54 +0000 2017
X-GM-THRID: 1584259521491508959
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread