2017-11-27 18:23:39

by Gustavo A. R. Silva

[permalink] [raw]
Subject: [PATCH] rxrpc: sendmsg: Fix variable overwrite in rxrpc_queue_packet

Value assigned to variable resend_at is overwritten before it can be used.

Fix this by removing the value overwrite as it seems that this is a
leftover code.

Addresses-Coverity-ID: 1462262
Fixes: beb8e5e4f38c ("rxrpc: Express protocol timeouts in terms of RTT")
Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
net/rxrpc/sendmsg.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/net/rxrpc/sendmsg.c b/net/rxrpc/sendmsg.c
index a1c53ac..42060dd 100644
--- a/net/rxrpc/sendmsg.c
+++ b/net/rxrpc/sendmsg.c
@@ -233,7 +233,6 @@ static void rxrpc_queue_packet(struct rxrpc_sock *rx, struct rxrpc_call *call,
if (resend_at < 1)
resend_at = 1;

- resend_at = now + rxrpc_resend_timeout;
WRITE_ONCE(call->resend_at, resend_at);
rxrpc_reduce_call_timer(call, resend_at, now,
rxrpc_timer_set_for_send);
--
2.7.4


From 1585215977671744719@xxx Mon Nov 27 10:49:23 +0000 2017
X-GM-THRID: 1585215977671744719
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread