On Wed, Nov 22, 2017 at 10:52:14AM -0800, Mike Kravetz wrote:
> If the call __alloc_contig_migrate_range() in alloc_contig_range
> returns -EBUSY, processing continues so that test_pages_isolated()
> is called where there is a tracepoint to identify the busy pages.
> However, it is possible for busy pages to become available between
> the calls to these two routines. In this case, the range of pages
> may be allocated. Unfortunately, the original return code (ret
> == -EBUSY) is still set and returned to the caller. Therefore,
> the caller believes the pages were not allocated and they are leaked.
>
> Update comment to indicate that allocation is still possible even if
> __alloc_contig_migrate_range returns -EBUSY. Also, clear return code
> in this case so that it is not accidentally used or returned to caller.
>
> Fixes: 8ef5849fa8a2 ("mm/cma: always check which page caused allocation failure")
> Cc: <[email protected]>
> Signed-off-by: Mike Kravetz <[email protected]>
Good catch!!
Acked-by: Joonsoo Kim <[email protected]>
Thanks.
From 1585239694666007168@xxx Mon Nov 27 17:06:22 +0000 2017
X-GM-THRID: 1584615256438578356
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread