2017-11-29 15:44:16

by Daniel Vetter

Subject: [PATCH 0/2] lockdep cross-release fallout from -rc1

Hi all,

-rc1 set our CI on fire with a pile of issues that cross-release
highlights. The two patches in this series get things back into working
order on our side, so we pulled them into our local branches to unblock CI
and drm/i915.

But they're ofc far from polished, so pls look at this more as a bug
report than bugfix submission :-)

Cheers, Daniel

Daniel Vetter (2):
lockdep: finer-grained completion key for kthread
lockdep: Up MAX_LOCKDEP_CHAINS

include/linux/kthread.h | 48 ++++++++++++++++++++++----
kernel/kthread.c | 70 ++++++++++++++++++++++++++------------
kernel/locking/lockdep_internals.h | 2 +-
3 files changed, 91 insertions(+), 29 deletions(-)

--
2.15.0


From 1585377823279215782@xxx Wed Nov 29 05:41:51 +0000 2017
X-GM-THRID: 1585224158905538418
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread

2017-11-29 15:44:31

by Daniel Vetter

Subject: [PATCH 2/2] lockdep: Up MAX_LOCKDEP_CHAINS

cross-release ftl

>From Chris:

"Fwiw, this isn't cross-release but us reloading the module many times,
creating a whole host of new lockclasses. Even more fun is when the
module gets a slightly different address and the new lock address hashes
into an old lock...

"I did think about a module-hook to revoke the stale lockclasses, but
that still leaves all the hashed chains.

"This particular nuisance was temporarily pushed back by teaching igt not
to reload i915.ko on a whim."

Cc: Tvrtko Ursulin <[email protected]>
Cc: Marta Lofstedt <[email protected]>
References: https://bugs.freedesktop.org/show_bug.cgi?id=103707
Signed-off-by: Daniel Vetter <[email protected]>
---
kernel/locking/lockdep_internals.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/locking/lockdep_internals.h b/kernel/locking/lockdep_internals.h
index d459d624ba2a..41630a5385c6 100644
--- a/kernel/locking/lockdep_internals.h
+++ b/kernel/locking/lockdep_internals.h
@@ -69,7 +69,7 @@ enum {
#else
#define MAX_LOCKDEP_ENTRIES 32768UL

-#define MAX_LOCKDEP_CHAINS_BITS 16
+#define MAX_LOCKDEP_CHAINS_BITS 17

/*
* Stack-trace: tightly packed array of stack backtrace
--
2.15.0


From 1585201262731284192@xxx Mon Nov 27 06:55:30 +0000 2017
X-GM-THRID: 1585201262731284192
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread