On Thu, Nov 30, 2017 at 10:39:48AM -0500, Joshua Abraham wrote:
> diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c
> index 6feecc55d2bc..6de66eaad96b 100644
> --- a/drivers/staging/xgifb/XGI_main_26.c
> +++ b/drivers/staging/xgifb/XGI_main_26.c
> @@ -34,16 +34,16 @@ static void dumpVGAReg(struct xgifb_video_info *xgifb_info)
> {
> u8 i, reg;
>
> - xgifb_reg_set(XGISR, 0x05, 0x86);
> + xgifb_reg_set(xgifb_info->dev_info.P3c4, 0x05, 0x86);
This patch is OK, but it might be nicer to create a temporary variable
so the lines are not so long:
struct vb_device_info *vb = &xgifb_info->dev_info;
u8 i, reg;
xgifb_reg_set(vb->P3c4, 0x05, 0x86);
I chose "vb" based on the struct name... "dev" and "info" aren't very
useful in a name because there are a lot of devices and lots of types
of info.
regards,
dan carpneter
On Fri, Dec 01, 2017 at 10:12:30AM +0300, Dan Carpenter wrote:
> On Thu, Nov 30, 2017 at 10:39:48AM -0500, Joshua Abraham wrote:
> > diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c
> > index 6feecc55d2bc..6de66eaad96b 100644
> > --- a/drivers/staging/xgifb/XGI_main_26.c
> > +++ b/drivers/staging/xgifb/XGI_main_26.c
> > @@ -34,16 +34,16 @@ static void dumpVGAReg(struct xgifb_video_info *xgifb_info)
> > {
> > u8 i, reg;
> >
> > - xgifb_reg_set(XGISR, 0x05, 0x86);
> > + xgifb_reg_set(xgifb_info->dev_info.P3c4, 0x05, 0x86);
>
> This patch is OK, but it might be nicer to create a temporary variable
> so the lines are not so long:
>
> struct vb_device_info *vb = &xgifb_info->dev_info;
> u8 i, reg;
>
> xgifb_reg_set(vb->P3c4, 0x05, 0x86);
>
> I chose "vb" based on the struct name... "dev" and "info" aren't very
> useful in a name because there are a lot of devices and lots of types
> of info.
>
> regards,
> dan carpneter
>
That is indeed MUCH more readable. Thanks, I'll work on this today.
-Josh