2017-12-05 09:42:37

by Dave Young

Subject: [PATCH] efi: add comment to avoid future expanding of sysfs systab

/sys/firmware/efi/systab shows several different values, it breaks sysfs
one file one value design. But since there are already userspace tools
depend on it eg. kexec-tools so add code comment to alert future expanding
of this file.

Signed-off-by: Dave Young <[email protected]>
---
drivers/firmware/efi/efi.c | 2 ++
1 file changed, 2 insertions(+)

--- linux-x86.orig/drivers/firmware/efi/efi.c
+++ linux-x86/drivers/firmware/efi/efi.c
@@ -109,6 +109,8 @@ struct kobject *efi_kobj;
/*
* Let's not leave out systab information that snuck into
* the efivars driver
+ * Note, do not add more fields in systab sysfs file as it breaks sysfs
+ * one value per file rule!
*/
static ssize_t systab_show(struct kobject *kobj,
struct kobj_attribute *attr, char *buf)

2017-12-05 10:16:18

by Greg Kroah-Hartman

Subject: Re: [PATCH] efi: add comment to avoid future expanding of sysfs systab

On Tue, Dec 05, 2017 at 05:42:27PM +0800, Dave Young wrote:
> /sys/firmware/efi/systab shows several different values, it breaks sysfs
> one file one value design. But since there are already userspace tools
> depend on it eg. kexec-tools so add code comment to alert future expanding
> of this file.
>
> Signed-off-by: Dave Young <[email protected]>

Reviewed-by: Greg Kroah-Hartman <[email protected]>