2017-12-06 10:31:49

by Neil Singh

[permalink] [raw]
Subject: [PATCH] staging: rtl8712: Cleanup codestyle

Fix following checkpatch.pl messages:

WARNING: line over 80 characters
1000: FILE: rtl871x_security.c:1000:

ERROR: code indent should use tabs where possible
1408: FILE: rtl871x_security.c:1408:

WARNING: please, no spaces at the start of a line
1408: FILE: rtl871x_security.c:1408:

Signed-off-by: Neil Singh <[email protected]>
---
drivers/staging/rtl8712/rtl871x_security.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8712/rtl871x_security.c b/drivers/staging/rtl8712/rtl871x_security.c
index 56d36f6..ed3a00f 100644
--- a/drivers/staging/rtl8712/rtl871x_security.c
+++ b/drivers/staging/rtl8712/rtl871x_security.c
@@ -997,8 +997,9 @@ static void construct_mic_header2(u8 *mic_header2, u8 *mpdu, sint a4_exists,
/* Builds the last MIC header block from */
/* header fields. */
/************************************************/
-static void construct_ctr_preload(u8 *ctr_preload, sint a4_exists, sint qc_exists,
- u8 *mpdu, u8 *pn_vector, sint c)
+static void construct_ctr_preload(u8 *ctr_preload,
+ sint a4_exists, sint qc_exists,
+ u8 *mpdu, u8 *pn_vector, sint c)
{
sint i;

@@ -1405,7 +1406,7 @@ u32 r8712_aes_decrypt(struct _adapter *padapter, u8 *precvframe)
void r8712_use_tkipkey_handler(struct timer_list *t)
{
struct _adapter *padapter =
- from_timer(padapter, t, securitypriv.tkip_timer);
+ from_timer(padapter, t, securitypriv.tkip_timer);

padapter->securitypriv.busetkipkey = true;
}
--
2.1.4


2017-12-06 11:15:35

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] staging: rtl8712: Cleanup codestyle

On Wed, Dec 06, 2017 at 05:31:38PM +0700, Neil Singh wrote:
> Fix following checkpatch.pl messages:
>
> WARNING: line over 80 characters
> 1000: FILE: rtl871x_security.c:1000:
>
> ERROR: code indent should use tabs where possible
> 1408: FILE: rtl871x_security.c:1408:
>
> WARNING: please, no spaces at the start of a line
> 1408: FILE: rtl871x_security.c:1408:

That's multiple things, so this should be multiple patches...

thanks,

greg k-h