2017-12-09 15:07:31

by Vincent Legoll

Subject: [PATCH] ptp: make PTP a menuconfig to ease disabling it all

No need to get into the submenu to disable all PTP-related
config entries.

This makes it easier to disable all PTP config options
without entering the submenu. It will also enable one
to see that en/dis-abled state from the outside menu.

This is only intended to change menuconfig UI, not change
the config dependencies.

Signed-off-by: Vincent Legoll <[email protected]>
---
drivers/ptp/Kconfig | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/ptp/Kconfig b/drivers/ptp/Kconfig
index a21ad10d613c..d3f3a9f2b0b1 100644
--- a/drivers/ptp/Kconfig
+++ b/drivers/ptp/Kconfig
@@ -2,7 +2,10 @@
# PTP clock support configuration
#

-menu "PTP clock support"
+menuconfig PTP_MENU
+ bool"PTP clock support"
+
+if PTP_MENU

config PTP_1588_CLOCK
tristate "PTP clock support"
@@ -118,4 +121,4 @@ config PTP_1588_CLOCK_KVM
To compile this driver as a module, choose M here: the module
will be called ptp_kvm.

-endmenu
+endif # PTP_MENU
--
2.14.1

2017-12-11 03:28:42

by Richard Cochran

Subject: Re: [PATCH] ptp: make PTP a menuconfig to ease disabling it all

On Sat, Dec 09, 2017 at 04:07:15PM +0100, Vincent Legoll wrote:
> No need to get into the submenu to disable all PTP-related
> config entries.
>
> This makes it easier to disable all PTP config options
> without entering the submenu. It will also enable one
> to see that en/dis-abled state from the outside menu.
>
> This is only intended to change menuconfig UI, not change
> the config dependencies.

NAK, you are introducing a new config option for no good reason.

Sorry,
Richard

2017-12-13 09:01:20

by Vincent Legoll

Subject: Re: [PATCH] ptp: make PTP a menuconfig to ease disabling it all

Hello,

On Mon, Dec 11, 2017 at 4:28 AM, Richard Cochran
<[email protected]> wrote:
> NAK, you are introducing a new config option for no good reason.

I don't think there are alternatives available in Kconfig to achieve
the goal of easing the management of a .config with menuconfig.

Do you have any idea about how to do it without using menuconfig ?

Thanks

--
Vincent Legoll

2017-12-13 15:22:14

by Richard Cochran

Subject: Re: [PATCH] ptp: make PTP a menuconfig to ease disabling it all

On Wed, Dec 13, 2017 at 10:01:15AM +0100, Vincent Legoll wrote:
> I don't think there are alternatives available in Kconfig to achieve
> the goal of easing the management of a .config with menuconfig.
>
> Do you have any idea about how to do it without using menuconfig ?

scripts/config

HTH,
Richard