2017-12-11 15:45:11

by Mauro Carvalho Chehab

[permalink] [raw]
Subject: Re: [PATCH v2 5/6] [media] cxusb: implement Medion MD95700 digital / analog coexistence

Em Tue, 10 Oct 2017 23:36:55 +0200
"Maciej S. Szmigiero" <[email protected]> escreveu:

> This patch prepares cxusb driver for supporting the analog part of
> Medion 95700 (previously only the digital - DVB - mode was supported).
>
> Specifically, it adds support for:
> * switching the device between analog and digital modes of operation,
> * enforcing that only one mode is active at the same time due to hardware
> limitations.
>
> Actual implementation of the analog mode will be provided by the next
> commit.
>
> Signed-off-by: Maciej S. Szmigiero <[email protected]>

This patch doesn't apply:

Hunk #2 FAILED at 25.
Hunk #3 FAILED at 47.
Hunk #4 succeeded at 90 (offset 1 line).
Hunk #5 succeeded at 102 (offset 1 line).
Hunk #6 succeeded at 262 (offset 1 line).
Hunk #7 succeeded at 270 (offset 1 line).
Hunk #8 succeeded at 389 (offset 2 lines).
Hunk #9 succeeded at 683 (offset 2 lines).
Hunk #10 succeeded at 799 (offset 2 lines).
Hunk #11 succeeded at 1533 (offset 2 lines).
Hunk #12 succeeded at 1644 (offset 2 lines).
Hunk #13 succeeded at 1770 (offset 2 lines).
Hunk #14 succeeded at 1783 (offset 2 lines).
Hunk #15 succeeded at 1803 (offset 2 lines).
Hunk #16 succeeded at 1879 (offset 2 lines).
Hunk #17 succeeded at 2649 (offset 2 lines).
2 out of 17 hunks FAILED
checking file drivers/media/usb/dvb-usb/cxusb.h
Hunk #1 succeeded at 2 (offset 1 line).
Hunk #2 succeeded at 37 (offset 1 line).
Hunk #3 succeeded at 49 (offset 1 line).
checking file drivers/media/usb/dvb-usb/dvb-usb-dvb.c
Hunk #1 succeeded at 15 (offset 1 line).
Hunk #2 succeeded at 25 (offset 1 line).
Hunk #3 succeeded at 43 (offset 1 line).
Hunk #4 succeeded at 64 (offset 1 line).
Hunk #5 succeeded at 90 (offset 1 line).
checking file drivers/media/usb/dvb-usb/dvb-usb-init.c
checking file drivers/media/usb/dvb-usb/dvb-usb.h
Hunk #1 succeeded at 143 (offset 1 line).
Hunk #2 succeeded at 235 (offset 1 line).
Hunk #3 succeeded at 281 (offset 1 line).
drivers/media/usb/dvb-usb/cxusb.c | 450 +++++++++++++++++++++++++++----
drivers/media/usb/dvb-usb/cxusb.h | 48 +++
drivers/media/usb/dvb-usb/dvb-usb-dvb.c | 20 +
drivers/media/usb/dvb-usb/dvb-usb-init.c | 13
drivers/media/usb/dvb-usb/dvb-usb.h | 8
5 files changed, 486 insertions(+), 53 deletions(-)


2017-12-11 15:48:09

by Maciej S. Szmigiero

[permalink] [raw]
Subject: Re: [PATCH v2 5/6] [media] cxusb: implement Medion MD95700 digital / analog coexistence

On 11.12.2017 16:45, Mauro Carvalho Chehab wrote:
> Em Tue, 10 Oct 2017 23:36:55 +0200
> "Maciej S. Szmigiero" <[email protected]> escreveu:
>
>> This patch prepares cxusb driver for supporting the analog part of
>> Medion 95700 (previously only the digital - DVB - mode was supported).
>>
>> Specifically, it adds support for:
>> * switching the device between analog and digital modes of operation,
>> * enforcing that only one mode is active at the same time due to hardware
>> limitations.
>>
>> Actual implementation of the analog mode will be provided by the next
>> commit.
>>
>> Signed-off-by: Maciej S. Szmigiero <[email protected]>
>
> This patch doesn't apply:
>
> Hunk #2 FAILED at 25.
> Hunk #3 FAILED at 47.
(..)

Probably it has already bit-rotted since October - will try to
respin within two weeks (while addressing your comments to patch 1,
too.)

Maciej