2017-12-13 19:39:24

by Corentin Labbe

[permalink] [raw]
Subject: [PATCH 1/2] arm: dts: sun8i: a83t: remove leading zero from cpucfg node address

This will fix the following warning:
Warning (simple_bus_reg): Node /soc/cpucfg@01700000 simple-bus unit address format error, expected "1700000"

Signed-off-by: Corentin Labbe <[email protected]>
---
arch/arm/boot/dts/sun8i-a83t.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi
index 7b372acf4bf6..715719f9ea2e 100644
--- a/arch/arm/boot/dts/sun8i-a83t.dtsi
+++ b/arch/arm/boot/dts/sun8i-a83t.dtsi
@@ -377,7 +377,7 @@
#reset-cells = <1>;
};

- cpucfg@01700000 {
+ cpucfg@1700000 {
compatible = "allwinner,sun9i-a80-cpucfg";
reg = <0x01700000 0x100>;
};
--
2.13.6


2017-12-13 19:39:34

by Corentin Labbe

[permalink] [raw]
Subject: [PATCH 2/2] arm: dts: sun8i: a83t: Add an unit address to the memory node

This will fix the following warning:
Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name

Signed-off-by: Corentin Labbe <[email protected]>
---
arch/arm/boot/dts/sun8i-a83t.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi
index 715719f9ea2e..bddde0141f24 100644
--- a/arch/arm/boot/dts/sun8i-a83t.dtsi
+++ b/arch/arm/boot/dts/sun8i-a83t.dtsi
@@ -160,7 +160,7 @@
};
};

- memory {
+ memory@40000000 {
reg = <0x40000000 0x80000000>;
device_type = "memory";
};
--
2.13.6

2017-12-14 09:53:53

by Maxime Ripard

[permalink] [raw]
Subject: Re: [PATCH 1/2] arm: dts: sun8i: a83t: remove leading zero from cpucfg node address

Hi,

On Wed, Dec 13, 2017 at 08:37:14PM +0100, Corentin Labbe wrote:
> This will fix the following warning:
> Warning (simple_bus_reg): Node /soc/cpucfg@01700000 simple-bus unit address format error, expected "1700000"
>
> Signed-off-by: Corentin Labbe <[email protected]>
> ---
> arch/arm/boot/dts/sun8i-a83t.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi
> index 7b372acf4bf6..715719f9ea2e 100644
> --- a/arch/arm/boot/dts/sun8i-a83t.dtsi
> +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi
> @@ -377,7 +377,7 @@
> #reset-cells = <1>;
> };
>
> - cpucfg@01700000 {
> + cpucfg@1700000 {
> compatible = "allwinner,sun9i-a80-cpucfg";
> reg = <0x01700000 0x100>;

That node isn't upstream.

Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Attachments:
(No filename) (915.00 B)
 signature.asc (833.00 B)
 Download all attachments

2017-12-14 09:54:33

by Maxime Ripard

[permalink] [raw]
Subject: Re: [PATCH 2/2] arm: dts: sun8i: a83t: Add an unit address to the memory node

Hi,

On Wed, Dec 13, 2017 at 08:37:15PM +0100, Corentin Labbe wrote:
> This will fix the following warning:
> Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name
>
> Signed-off-by: Corentin Labbe <[email protected]>
> ---
> arch/arm/boot/dts/sun8i-a83t.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi
> index 715719f9ea2e..bddde0141f24 100644
> --- a/arch/arm/boot/dts/sun8i-a83t.dtsi
> +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi
> @@ -160,7 +160,7 @@
> };
> };
>
> - memory {
> + memory@40000000 {
> reg = <0x40000000 0x80000000>;
> device_type = "memory";
> };

Can't we just get rid of the memory node entirely? U-Boot will add it
for us anyway.

Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Attachments:
(No filename) (918.00 B)
 signature.asc (833.00 B)
 Download all attachments