2017-12-14 09:44:42

by Quentin Schulz

Subject: [PATCH] pinctrl: axp209: add missing Kconfig dependencies

This fixes some compilation issues.

GENERIC_PINCONF and OF at least for pinconf_generic_dt_*, PINMUX at
least for pinmux_ops and GPIOLIB for at least gpio_chip.

Fixes: 23f75d7dfa92 ("pinctrl: axp209: add pinctrl features")

Reported-by: Randy Dunlab <[email protected]>
Signed-off-by: Quentin Schulz <[email protected]>
---
drivers/pinctrl/Kconfig | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index ce126955212c..1dd445116432 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -66,6 +66,10 @@ config PINCTRL_AS3722
config PINCTRL_AXP209
tristate "X-Powers AXP209 PMIC pinctrl and GPIO Support"
depends on MFD_AXP20X
+ depends on OF
+ select PINMUX
+ select GENERIC_PINCONF
+ select GPIOLIB
help
AXP PMICs provides multiple GPIOs that can be muxed for different
functions. This driver bundles a pinctrl driver to select the function
--
2.14.1

2017-12-14 18:22:46

by Randy Dunlap

Subject: Re: [PATCH] pinctrl: axp209: add missing Kconfig dependencies

On 12/14/2017 01:43 AM, Quentin Schulz wrote:
> This fixes some compilation issues.
>
> GENERIC_PINCONF and OF at least for pinconf_generic_dt_*, PINMUX at
> least for pinmux_ops and GPIOLIB for at least gpio_chip.
>
> Fixes: 23f75d7dfa92 ("pinctrl: axp209: add pinctrl features")
>
> Reported-by: Randy Dunlab <[email protected]>
> Signed-off-by: Quentin Schulz <[email protected]>

Acked-by: Randy Dunlap <[email protected]>

Thanks.

> ---
> drivers/pinctrl/Kconfig | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index ce126955212c..1dd445116432 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -66,6 +66,10 @@ config PINCTRL_AS3722
> config PINCTRL_AXP209
> tristate "X-Powers AXP209 PMIC pinctrl and GPIO Support"
> depends on MFD_AXP20X
> + depends on OF
> + select PINMUX
> + select GENERIC_PINCONF
> + select GPIOLIB
> help
> AXP PMICs provides multiple GPIOs that can be muxed for different
> functions. This driver bundles a pinctrl driver to select the function
>


--
~Randy

2017-12-20 08:14:20

by Linus Walleij

Subject: Re: [PATCH] pinctrl: axp209: add missing Kconfig dependencies

On Thu, Dec 14, 2017 at 10:43 AM, Quentin Schulz
<[email protected]> wrote:

> This fixes some compilation issues.
>
> GENERIC_PINCONF and OF at least for pinconf_generic_dt_*, PINMUX at
> least for pinmux_ops and GPIOLIB for at least gpio_chip.
>
> Fixes: 23f75d7dfa92 ("pinctrl: axp209: add pinctrl features")
>
> Reported-by: Randy Dunlab <[email protected]>

Fixed that name.

> Signed-off-by: Quentin Schulz <[email protected]>

Patch applied with Randy's ACK.

Yours,
Linus Walleij