2017-12-15 20:51:27

by Michal Suchánek

[permalink] [raw]
Subject: Re: [PATCH v9 1/8] lib/cmdline.c: remove quotes symmetrically

On Wed, 15 Nov 2017 20:46:56 +0530
Hari Bathini <[email protected]> wrote:

> From: Michal Suchanek <[email protected]>
>
> Remove quotes from argument value only if there is qoute on both
> sides.
>
> Signed-off-by: Michal Suchanek <[email protected]>
> ---
> lib/cmdline.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/lib/cmdline.c b/lib/cmdline.c
> index 171c19b..6d398a8 100644
> --- a/lib/cmdline.c
> +++ b/lib/cmdline.c
> @@ -227,14 +227,12 @@ char *next_arg(char *args, char **param, char
> **val) *val = args + equals + 1;
>
> /* Don't include quotes in value. */
> - if (**val == '"') {
> - (*val)++;
> - if (args[i-1] == '"')
> - args[i-1] = '\0';
> + if ((args[i-1] == '"') && ((quoted) || (**val ==
> '"'))) {
> + args[i-1] = '\0';
> + if (!quoted)
> + (*val)++;
> }
> }
> - if (quoted && args[i-1] == '"')
> - args[i-1] = '\0';
>
> if (args[i]) {
> args[i] = '\0';
>

This was only useful as separate patch with the incremental fadump
update. Since the fadump update is squashed in this refresh series this
can be squashed with the following lib/cmdline patch as well.

Thanks

Michal