2017-12-21 15:53:34

by Vasyl Gomonovych

Subject: [PATCH] dmaengine: cppi41: Fix channel queues array size check

The test should be >= ARRAY_SIZE() instead of > ARRAY_SIZE().

Signed-off-by: Vasyl Gomonovych <[email protected]>
---
drivers/dma/cppi41.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/cppi41.c b/drivers/dma/cppi41.c
index f7e965f63274..d9bee65a18a4 100644
--- a/drivers/dma/cppi41.c
+++ b/drivers/dma/cppi41.c
@@ -934,7 +934,7 @@ static bool cpp41_dma_filter_fn(struct dma_chan *chan, void *param)

BUILD_BUG_ON(ARRAY_SIZE(am335x_usb_queues_rx) !=
ARRAY_SIZE(am335x_usb_queues_tx));
- if (WARN_ON(cchan->port_num > ARRAY_SIZE(am335x_usb_queues_rx)))
+ if (WARN_ON(cchan->port_num >= ARRAY_SIZE(am335x_usb_queues_rx)))
return false;

cchan->q_num = queues[cchan->port_num].submit;
--
1.9.1

2017-12-22 12:13:32

by Vinod Koul

Subject: Re: [PATCH] dmaengine: cppi41: Fix channel queues array size check

On Thu, Dec 21, 2017 at 09:23:04PM +0530, Vasyl Gomonovych wrote:
> The test should be >= ARRAY_SIZE() instead of > ARRAY_SIZE().

Applied, thanks

--
~Vinod